Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(278)

Unified Diff: sdk/lib/_internal/pub/test/validator/compiled_dartdoc_test.dart

Issue 599303002: Don't use .gitignore when determining what to build/serve/run. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sdk/lib/_internal/pub/test/validator/compiled_dartdoc_test.dart
diff --git a/sdk/lib/_internal/pub/test/validator/compiled_dartdoc_test.dart b/sdk/lib/_internal/pub/test/validator/compiled_dartdoc_test.dart
index 38ee28499a4971794183290c79b30f6eda9ca1c0..d41f7486ab1ac4042a7ec88a8dae6f645556ed55 100644
--- a/sdk/lib/_internal/pub/test/validator/compiled_dartdoc_test.dart
+++ b/sdk/lib/_internal/pub/test/validator/compiled_dartdoc_test.dart
@@ -33,73 +33,22 @@ main() {
]).create();
expectNoValidationError(compiledDartdoc);
});
-
- integration('contains compiled dartdoc in a hidden directory', () {
- ensureGit();
-
- d.dir(appPath, [
- d.dir(".doc-out", [
- d.file('nav.json', ''),
- d.file('index.html', ''),
- d.file('styles.css', ''),
- d.file('dart-logo-small.png', ''),
- d.file('client-live-nav.js', '')
- ])
- ]).create();
- expectNoValidationError(compiledDartdoc);
- });
-
- integration('contains compiled dartdoc in a gitignored directory', () {
- ensureGit();
-
- d.git(appPath, [
- d.dir("doc-out", [
- d.file('nav.json', ''),
- d.file('index.html', ''),
- d.file('styles.css', ''),
- d.file('dart-logo-small.png', ''),
- d.file('client-live-nav.js', '')
- ]),
- d.file(".gitignore", "/doc-out")
- ]).create();
- expectNoValidationError(compiledDartdoc);
- });
});
- group("should consider a package invalid if it", () {
- integration('contains compiled dartdoc', () {
- d.validPackage.create();
-
- d.dir(appPath, [
- d.dir('doc-out', [
- d.file('nav.json', ''),
- d.file('index.html', ''),
- d.file('styles.css', ''),
- d.file('dart-logo-small.png', ''),
- d.file('client-live-nav.js', '')
- ])
- ]).create();
-
- expectValidationWarning(compiledDartdoc);
- });
-
- integration('contains compiled dartdoc in a non-gitignored hidden '
- 'directory', () {
- ensureGit();
-
- d.validPackage.create();
-
- d.git(appPath, [
- d.dir('.doc-out', [
- d.file('nav.json', ''),
- d.file('index.html', ''),
- d.file('styles.css', ''),
- d.file('dart-logo-small.png', ''),
- d.file('client-live-nav.js', '')
- ])
- ]).create();
-
- expectValidationWarning(compiledDartdoc);
- });
nweiz 2014/09/25 00:22:31 This should still work as it used to, right? Since
Bob Nystrom 2014/09/25 00:36:55 Oh, duh. Done.
+ integration("should consider a package invalid if it contains compiled "
+ "dartdoc", () {
+ d.validPackage.create();
+
+ d.dir(appPath, [
+ d.dir('doc-out', [
+ d.file('nav.json', ''),
+ d.file('index.html', ''),
+ d.file('styles.css', ''),
+ d.file('dart-logo-small.png', ''),
+ d.file('client-live-nav.js', '')
+ ])
+ ]).create();
+
+ expectValidationWarning(compiledDartdoc);
});
}

Powered by Google App Engine
This is Rietveld 408576698