Issue 599293002: Implement strict and non-strict union types behind flag [strictUnionTypes].

Issue 599293002: Implement strict and non-strict union types behind flag [strictUnionTypes]. (Closed)

Created:
6 years, 3 months ago by Nathan Collins

Modified:
6 years, 2 months ago

Reviewers:
jwren, Brian Wilkerson

CC:
reviews_dartlang.org, ricow1

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Implement strict and non-strict union types behind flag [strictUnionTypes]. This only covers existing union types code. In particular, there is still no support for fields on union types (treated as dynamic currently, so no hints ever). It remains to implement strict and non-strict versions of the completion UI. That's in progress and will go up in another CL because this CL was getting too big. R=brianwilkerson@google.com, jwren@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=40679

Patch Set 1 #

Total comments: 4

Patch Set 2 : Address @brianwilkerson comments. #

Created: 6 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+89 lines, -36 lines)			Patch
M	editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/resolver/ElementResolver.java	View		2 chunks	+14 lines, -1 line	0 comments	Download
M	editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/type/FunctionTypeImpl.java	View		1 chunk	+1 line, -1 line	0 comments	Download
M	editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/type/InterfaceTypeImpl.java	View		1 chunk	+1 line, -1 line	0 comments	Download
M	editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/type/TypeImpl.java	View	1	2 chunks	+38 lines, -2 lines	0 comments	Download
M	editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/type/UnionTypeImpl.java	View		5 chunks	+35 lines, -31 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Brian Wilkerson

LGTM https://codereview.chromium.org/599293002/diff/1/editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/type/TypeImpl.java File editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/type/TypeImpl.java (right): https://codereview.chromium.org/599293002/diff/1/editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/type/TypeImpl.java#newcode184 editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/type/TypeImpl.java:184: for (Type l : ((UnionType) this).getElements()) { "l" ...

6 years, 2 months ago (2014-09-25 13:51:40 UTC) #2

Nathan Collins

https://codereview.chromium.org/599293002/diff/1/editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/type/TypeImpl.java File editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/type/TypeImpl.java (right): https://codereview.chromium.org/599293002/diff/1/editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/type/TypeImpl.java#newcode184 editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/type/TypeImpl.java:184: for (Type l : ((UnionType) this).getElements()) { On 2014/09/25 ...

6 years, 2 months ago (2014-09-25 16:16:17 UTC) #4

Nathan Collins

6 years, 2 months ago (2014-09-25 16:16:46 UTC) #5

Message was sent while issue was closed.

Committed patchset #2 manually as 40679 (presubmit successful).

Expand Messages | Collapse Messages