Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Issue 599283002: Move paint code from RenderSVGText to SVGTextPainter (Closed)

Created:
6 years, 3 months ago by pdr.
Modified:
6 years, 3 months ago
Reviewers:
chrishtr
CC:
blink-reviews, blink-reviews-rendering, chrome-slimming-paint_google.com, krit, eae+blinkwatch, ed+blinkwatch_opera.com, f(malita), fs, gyuyoung.kim_webkit.org, jchaffraix+rendering, kouhei+svg_chromium.org, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, pdr+svgwatchlist_chromium.org, rwlbuis, rune+blink, Stephen Chennney, zoltan1
Project:
blink
Visibility:
Public.

Description

Move paint code from RenderSVGText to SVGTextPainter This patch moves the RenderSVGText paint code into the new SVGTextPainter. This is a straight code move and the only change that was need was to expose localToParentTransform as public on RenderSVGText. BUG=412088 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=182642

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+66 lines, -20 lines) Patch
M Source/core/core.gypi View 1 chunk +2 lines, -0 lines 0 comments Download
A Source/core/paint/SVGTextPainter.h View 1 chunk +24 lines, -0 lines 0 comments Download
A Source/core/paint/SVGTextPainter.cpp View 1 chunk +36 lines, -0 lines 0 comments Download
M Source/core/rendering/svg/RenderSVGText.h View 2 chunks +2 lines, -1 line 0 comments Download
M Source/core/rendering/svg/RenderSVGText.cpp View 3 chunks +2 lines, -19 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
pdr.
6 years, 3 months ago (2014-09-24 23:26:25 UTC) #2
chrishtr
lgtm
6 years, 3 months ago (2014-09-24 23:28:30 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/599283002/1
6 years, 3 months ago (2014-09-24 23:29:26 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_gn_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/linux_chromium_gn_rel/builds/11573)
6 years, 3 months ago (2014-09-24 23:41:26 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/599283002/1
6 years, 3 months ago (2014-09-24 23:48:43 UTC) #9
commit-bot: I haz the power
6 years, 3 months ago (2014-09-25 00:47:57 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as 182642

Powered by Google App Engine
This is Rietveld 408576698