chrome/browser/resources/chromeos/login/oobe.html - Issue 599273004: Polished UI for the host side of pairing flow.

Side by Side Diff: chrome/browser/resources/chromeos/login/oobe.html

Issue 599273004: Polished UI for the host side of pairing flow. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@merge_point

Patch Set: Removed TODO. Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« chrome/browser/resources/chromeos/login/login_common.js ('K') | « chrome/browser/resources/chromeos/login/login_resources.html ('k') | chrome/browser/resources/chromeos/login/oobe.js » ('j') | chrome/browser/resources/chromeos/login/oobe.js » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <!DOCTYPE html>	1 <!DOCTYPE html>

2 <html i18n-values="dir:textdirection;build:buildType;highlight:highlightStrength ">	2 <html i18n-values="dir:textdirection;build:buildType;highlight:highlightStrength ">

3 <head>	3 <head>

4 <meta charset="utf-8">	4 <meta charset="utf-8">

5 <meta name="google" value="notranslate">	5 <meta name="google" value="notranslate">

6 <title i18n-content="title"></title>	6 <title i18n-content="title"></title>

	7 <script src="chrome://oobe/polymer/platform/platform.js"></script>
	Nikita (slow) 2014/09/25 20:19:59 I suggest having all Polymer specific include/scri I suggest having all Polymer specific include/script/link elements grouped together. May as well add comment. dzhioev (left Google) 2014/09/26 22:56:11 It is not possible now: * custom element's CSS sho Show quoted text On 2014/09/25 20:19:59, Nikita Kostylev wrote: > I suggest having all Polymer specific include/script/link elements grouped > together. May as well add comment. It is not possible now: * custom element's CSS should be defined inside element definition. * We should all <script src="..."> inclusions of local JS files to oobe.js. Otherwise Grit will flatten them and they will not work. * platform.js should be included first.
	8 <include src="oobe-screen.html">

	9 <include src="html-echo.html">

7 <include src="login_resources.html">	10 <include src="login_resources.html">

	11 <link rel="stylesheet" href="roboto_font.css">
	Nikita (slow) 2014/09/25 20:19:59 Do you think whether this will have perfomance eff Do you think whether this will have perfomance effect on boot time? Specifically for cases when font is not needed? dzhioev (left Google) 2014/09/26 22:56:11 I doubt it. Show quoted text On 2014/09/25 20:19:59, Nikita Kostylev wrote: > Do you think whether this will have perfomance effect on boot time? > Specifically for cases when font is not needed? I doubt it.
8 <link rel="stylesheet" href="accessibility_menu.css">	12 <link rel="stylesheet" href="accessibility_menu.css">

9 <script src="chrome://oobe/oobe.js"></script>	13 <script src="chrome://oobe/oobe.js"></script>

10 </head>	14 </head>

11 <body class="oobe-display" i18n-values=".style.fontFamily:fontfamily;">	15 <body class="oobe-display" i18n-values=".style.fontFamily:fontfamily;">

12 <include src="screen_container.html">	16 <include src="screen_container.html">

13 <include src="accessibility_menu.html">	17 <include src="accessibility_menu.html">

14 <div id="popup-overlay" hidden>	18 <div id="popup-overlay" hidden>

15 <div id="installation-settings-popup">	19 <div id="installation-settings-popup">

16 <h1 i18n-content="eulaSystemInstallationSettings"></h1>	20 <h1 i18n-content="eulaSystemInstallationSettings"></h1>

17 <div class="popup-content-area">	21 <div class="popup-content-area">

(...skipping 10 matching lines...) Expand all Loading...
28 </div>	32 </div>

29 </div>	33 </div>

30 <button id="installation-settings-ok-button"	34 <button id="installation-settings-ok-button"

31 i18n-content="eulaSystemInstallationSettingsOkButton">	35 i18n-content="eulaSystemInstallationSettingsOkButton">

32 </button>	36 </button>

33 </div>	37 </div>

34 </div>	38 </div>

35 <script src="chrome://resources/js/i18n_template2.js"></script>	39 <script src="chrome://resources/js/i18n_template2.js"></script>

36 </body>	40 </body>

37 </html>	41 </html>

OLD	NEW