Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(159)

Issue 599273002: Revert of Revert of [AiS] Merge answers into highest-scoring result (Closed)

Created:
6 years, 3 months ago by jiayl
Modified:
6 years, 3 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@top-hit
Project:
chromium
Visibility:
Public.

Description

Revert of Revert of [AiS] Merge answers into highest-scoring result (patchset #1 id:1 of https://codereview.chromium.org/598253002/) Reason for revert: Broken GN build: http://build.chromium.org/p/chromium.linux/builders/Linux%20GN%20%28dbg%29/builds/13101 Original issue's description: > Revert of [AiS] Merge answers into highest-scoring result (patchset #6 id:100001 of https://codereview.chromium.org/584653004/) > > Reason for revert: > The new tests are flaky: > http://build.chromium.org/p/chromium.memory/builders/Linux%20ASan%20LSan%20Tests%20%283%29/builds/7944 > > Original issue's description: > > [AiS] Merge answers into highest-scoring result > > > > Answer contents and type must always be copied to the highest-scoring > > suggestion, to ensure answers are not lost due to suggestion > > deduplication. > > > > BUG=415836 > > R=mpearson > > > > Committed: https://crrev.com/978a4bf4a3be714950ed265660bd9566f7abd922 > > Cr-Commit-Position: refs/heads/master@{#296520} > > TBR=mpearson@google.com,mpearson@chromium.org,newt@chromium.org,groby@chromium.org > NOTREECHECKS=true > NOTRY=true > BUG=415836 > > Committed: https://crrev.com/ba5d32190d4f056b11738b050b94895b655c52f7 > Cr-Commit-Position: refs/heads/master@{#296555} TBR=mpearson@google.com,mpearson@chromium.org,newt@chromium.org,groby@chromium.org NOTREECHECKS=true NOTRY=true BUG=415836 Committed: https://crrev.com/bffe11cb0e62af7c8d11b0c89b528b5f6f619e55 Cr-Commit-Position: refs/heads/master@{#296573}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+204 lines, -0 lines) Patch
M components/components_tests.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M components/omnibox/base_search_provider.cc View 1 chunk +11 lines, -0 lines 0 comments Download
A components/omnibox/base_search_provider_unittest.cc View 1 chunk +192 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
jiayl
Created Revert of Revert of [AiS] Merge answers into highest-scoring result
6 years, 3 months ago (2014-09-24 23:22:03 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/599273002/1
6 years, 3 months ago (2014-09-24 23:30:56 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/599273002/1
6 years, 3 months ago (2014-09-24 23:43:58 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1) as 120aea8257c1e485df62d5d4d75059d2674f145c
6 years, 3 months ago (2014-09-24 23:45:42 UTC) #7
commit-bot: I haz the power
6 years, 3 months ago (2014-09-24 23:47:24 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/bffe11cb0e62af7c8d11b0c89b528b5f6f619e55
Cr-Commit-Position: refs/heads/master@{#296573}

Powered by Google App Engine
This is Rietveld 408576698