easy-signin: Defer chrome restart until key ops finish.

easy-signin: Defer chrome restart until key ops finish.

BUG=412006
Committed: https://crrev.com/cfddc3601a6d355dae66317e07654e9d0c81eff8
Cr-Commit-Position: refs/heads/master@{#296983}

[xiyuan, 2014-09-24 23:11:46]

xiyuan@chromium.org changed reviewers:
+ nkostylev@chromium.org, tbarzic@google.com

[xiyuan, 2014-09-24 23:11:47]

This adds about 2 seconds when chrome restart is needed. :(

[tbarzic, 2014-09-24 23:13:44]

tbarzic@chromium.org changed reviewers:
+ tbarzic@chromium.org
- tbarzic@google.com

[Nikita (slow), 2014-09-25 07:34:26]

nkostylev@chromium.org changed reviewers:
+ alemate@chromium.org

[Nikita (slow), 2014-09-25 07:34:27]

+alemate@

I think we need to take a different approach:

1. Make sure that no operation has started when restart is needed.
After https://codereview.chromium.org/322533002 Chrome now restarts pretty early

2. Resume this operation after restart happened.

[Nikita (slow), 2014-09-25 07:35:48]

On 2014/09/25 07:34:27, Nikita Kostylev wrote:
> +alemate@
> 
> I think we need to take a different approach:
> 
> 1. Make sure that no operation has started when restart is needed.
> After https://codereview.chromium.org/322533002 Chrome now restarts pretty
early
> 
> 2. Resume this operation after restart happened.

I guess that's not quite possible per issue:

>> User credentials is lost during the restart. 

Is this needed to be done just once or on each sign in when restart is needed?
Can this be optimized so that 2 sec delay is not needed on each restart.

[xiyuan, 2014-09-25 15:28:18]

On 2014/09/25 07:35:48, Nikita Kostylev wrote:
> On 2014/09/25 07:34:27, Nikita Kostylev wrote:
> > +alemate@
> > 
> > I think we need to take a different approach:
> > 
> > 1. Make sure that no operation has started when restart is needed.
> > After https://codereview.chromium.org/322533002 Chrome now restarts pretty
> early
> > 
> > 2. Resume this operation after restart happened.
> 
> I guess that's not quite possible per issue:
> 
> >> User credentials is lost during the restart. 
> 
> Is this needed to be done just once or on each sign in when restart is needed?

The keys need to be re-created on each success sign-in. And we had to do it
before the restart because it needs user credentials.

> Can this be optimized so that 2 sec delay is not needed on each restart.

It does not add 2sec for each restart. It only adds for the first restart where
we had user credentials and there is running key operations.

[xiyuan, 2014-09-26 16:12:08]

ping?

[tbarzic, 2014-09-26 17:45:38]

lgtm

[xiyuan, 2014-09-26 18:18:48]

The CQ bit was checked by xiyuan@chromium.org

[commit-bot: I haz the power, 2014-09-26 18:19:38]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/599263002/20001

[commit-bot: I haz the power, 2014-09-26 18:32:03]

Committed patchset #2 (id:20001) as 85e37bbcddc2a1e7bb407d805e5a31794419d59b

[commit-bot: I haz the power, 2014-09-26 18:32:58]

Patchset 2 (id:??) landed as
https://crrev.com/cfddc3601a6d355dae66317e07654e9d0c81eff8
Cr-Commit-Position: refs/heads/master@{#296983}

[Nikita (slow), 2014-09-27 05:44:13]

On 2014/09/25 15:28:18, xiyuan wrote:
> On 2014/09/25 07:35:48, Nikita Kostylev wrote:
> > On 2014/09/25 07:34:27, Nikita Kostylev wrote:
> > > +alemate@
> > > 
> > > I think we need to take a different approach:
> > > 
> > > 1. Make sure that no operation has started when restart is needed.
> > > After https://codereview.chromium.org/322533002 Chrome now restarts pretty
> > early
> > > 
> > > 2. Resume this operation after restart happened.
> > 
> > I guess that's not quite possible per issue:
> > 
> > >> User credentials is lost during the restart. 
> > 
> > Is this needed to be done just once or on each sign in when restart is
needed?
> 
> The keys need to be re-created on each success sign-in. And we had to do it
> before the restart because it needs user credentials.

Does this mean on each GAIA sign in or when password has changed?
Or on each offline sign in?

> 
> > Can this be optimized so that 2 sec delay is not needed on each restart.
> 
> It does not add 2sec for each restart. It only adds for the first restart
where
> we had user credentials and there is running key operations.

[Nikita (slow), 2014-09-27 05:44:14]

On 2014/09/25 15:28:18, xiyuan wrote:
> On 2014/09/25 07:35:48, Nikita Kostylev wrote:
> > On 2014/09/25 07:34:27, Nikita Kostylev wrote:
> > > +alemate@
> > > 
> > > I think we need to take a different approach:
> > > 
> > > 1. Make sure that no operation has started when restart is needed.
> > > After https://codereview.chromium.org/322533002 Chrome now restarts pretty
> > early
> > > 
> > > 2. Resume this operation after restart happened.
> > 
> > I guess that's not quite possible per issue:
> > 
> > >> User credentials is lost during the restart. 
> > 
> > Is this needed to be done just once or on each sign in when restart is
needed?
> 
> The keys need to be re-created on each success sign-in. And we had to do it
> before the restart because it needs user credentials.

Does this mean on each GAIA sign in or when password has changed?
Or on each offline sign in?

> 
> > Can this be optimized so that 2 sec delay is not needed on each restart.
> 
> It does not add 2sec for each restart. It only adds for the first restart
where
> we had user credentials and there is running key operations.

[xiyuan, 2014-09-27 17:16:32]

On 2014/09/27 05:44:14, Nikita Kostylev wrote:
> On 2014/09/25 15:28:18, xiyuan wrote:
> > On 2014/09/25 07:35:48, Nikita Kostylev wrote:
> > > On 2014/09/25 07:34:27, Nikita Kostylev wrote:
> > > > +alemate@
> > > > 
> > > > I think we need to take a different approach:
> > > > 
> > > > 1. Make sure that no operation has started when restart is needed.
> > > > After https://codereview.chromium.org/322533002 Chrome now restarts
pretty
> > > early
> > > > 
> > > > 2. Resume this operation after restart happened.
> > > 
> > > I guess that's not quite possible per issue:
> > > 
> > > >> User credentials is lost during the restart. 
> > > 
> > > Is this needed to be done just once or on each sign in when restart is
> needed?
> > 
> > The keys need to be re-created on each success sign-in. And we had to do it
> > before the restart because it needs user credentials.
> 
> Does this mean on each GAIA sign in or when password has changed?
> Or on each offline sign in?
> 

The current behavior as discussed with Will and Darren is that we do this on
every success login, including Gaia, offline and the phone based. We probably
can try to push for only do it for phone based sign-in so that we don't use the
key twice.