Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(184)

Issue 599243002: Revert of Fix doodle verification URL. (Closed)

Created:
6 years, 3 months ago by jiayl
Modified:
6 years, 3 months ago
CC:
chromium-reviews, tfarina, groby-ooo-7-16
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Revert of Fix doodle verification URL. (patchset #3 id:40001 of https://codereview.chromium.org/587943003/) Reason for revert: Caused test failure: http://build.chromium.org/p/chromium.memory/builders/Linux%20ASan%20LSan%20Tests%20%283%29/builds/7944 Original issue's description: > Fix doodle verification URL. > > When verifying that the cached doodle is still valid, we load the doodle > URL and append the query param "async=es_dfp:<fingerprint>". Previously, > the ":" was being escape to "%3A", causing the server to respond with a > 400 error. This mollifies the server by keeping the colon unescaped. > > BUG=413845 > > Committed: https://crrev.com/673cc76103079eaada968c537c6605dbaf8d909c > Cr-Commit-Position: refs/heads/master@{#296512} TBR=justincohen@chromium.org,rsleevi@chromium.org,mmenke@chromium.org,newt@chromium.org NOTREECHECKS=true NOTRY=true BUG=413845 Committed: https://crrev.com/6101b6321585a402ffc7c45dbb4fc61bc36f0051 Cr-Commit-Position: refs/heads/master@{#296546}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -27 lines) Patch
M components/search_provider_logos/google_logo_api.cc View 2 chunks +2 lines, -16 lines 0 comments Download
M components/search_provider_logos/logo_tracker_unittest.cc View 2 chunks +2 lines, -11 lines 0 comments Download

Messages

Total messages: 11 (1 generated)
jiayl
Created Revert of Fix doodle verification URL.
6 years, 3 months ago (2014-09-24 22:48:30 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/599243002/1
6 years, 3 months ago (2014-09-24 22:50:10 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1) as b5b5e130df697879aa279ee59422b563a598b914
6 years, 3 months ago (2014-09-24 22:51:12 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/6101b6321585a402ffc7c45dbb4fc61bc36f0051 Cr-Commit-Position: refs/heads/master@{#296546}
6 years, 3 months ago (2014-09-24 22:51:58 UTC) #4
newt (away)
This revert looks like a mistake. The failing test (BaseSearchProviderTest.PreserveAnswersWhenDeduplicating) was added in another CL ...
6 years, 3 months ago (2014-09-24 22:58:41 UTC) #5
newt (away)
+groby FYI
6 years, 3 months ago (2014-09-24 22:59:56 UTC) #6
jiayl
Thanks for calling out. Please revert this revert. On Wed, Sep 24, 2014 at 3:59 ...
6 years, 3 months ago (2014-09-24 23:05:12 UTC) #7
groby-ooo-7-16
The test is not flaky, but LSAN detected a leak. Aren't these normally handled by ...
6 years, 3 months ago (2014-09-24 23:09:10 UTC) #9
newt (away)
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/606443004/ by newt@chromium.org. ...
6 years, 3 months ago (2014-09-24 23:18:06 UTC) #10
jiayl
6 years, 3 months ago (2014-09-24 23:18:53 UTC) #11
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/601763004/ by jiayl@chromium.org.

The reason for reverting is: Broke GN build:
http://build.chromium.org/p/chromium.linux/builders/Linux%20GN%20%28dbg%29/bu....

Powered by Google App Engine
This is Rietveld 408576698