Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(403)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 599213002: First cut at supporting activation in the window manager (Closed)

Created:
6 years, 3 months ago by Ben Goodger (Google)
Modified:
6 years, 2 months ago
Reviewers:
sky
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Hook up FocusController. R=sky@chromium.org BUG= Committed: https://crrev.com/c3d7eb256bc0dd9d53b136ed8184cf54fdd4830e Cr-Commit-Position: refs/heads/master@{#297245}

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : . #

Patch Set 4 : . #

Total comments: 2

Patch Set 5 : / #

Unified diffs Side-by-side diffs Delta from patch set Stats (+170 lines, -56 lines) Patch
M mojo/examples/wm_flow/wm/DEPS View 1 2 3 1 chunk +3 lines, -0 lines 0 comments Download
M mojo/examples/wm_flow/wm/frame_controller.h View 1 2 3 3 chunks +18 lines, -1 line 0 comments Download
M mojo/examples/wm_flow/wm/frame_controller.cc View 1 2 3 3 chunks +36 lines, -2 lines 0 comments Download
M mojo/examples/wm_flow/wm/wm.cc View 1 2 3 4 chunks +74 lines, -1 line 0 comments Download
M mojo/services/view_manager/connection_manager.h View 1 2 3 1 chunk +3 lines, -0 lines 0 comments Download
M mojo/services/view_manager/connection_manager.cc View 1 2 3 1 chunk +6 lines, -0 lines 0 comments Download
M mojo/services/view_manager/server_view.cc View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M mojo/services/view_manager/server_view_delegate.h View 1 2 3 1 chunk +4 lines, -0 lines 0 comments Download
M mojo/services/window_manager/window_manager_app.h View 1 2 3 4 4 chunks +4 lines, -2 lines 0 comments Download
M mojo/services/window_manager/window_manager_app.cc View 1 2 3 4 6 chunks +21 lines, -50 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Ben Goodger (Google)
There are still some issues/crashes but this almost works.
6 years, 2 months ago (2014-09-26 22:45:54 UTC) #2
sky
LGTM https://codereview.chromium.org/599213002/diff/60001/mojo/services/window_manager/window_manager_app.cc File mojo/services/window_manager/window_manager_app.cc (right): https://codereview.chromium.org/599213002/diff/60001/mojo/services/window_manager/window_manager_app.cc#newcode302 mojo/services/window_manager/window_manager_app.cc:302: View* view = GetViewForWindow(gained_active); Can't gained_active be NULL. ...
6 years, 2 months ago (2014-09-26 23:01:41 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/599213002/80001
6 years, 2 months ago (2014-09-29 19:21:28 UTC) #5
commit-bot: I haz the power
Committed patchset #5 (id:80001) as ee60ac72dcbdbbab7f82d9961a12213247481a1c
6 years, 2 months ago (2014-09-29 20:28:49 UTC) #6
commit-bot: I haz the power
6 years, 2 months ago (2014-09-29 20:29:23 UTC) #7
Message was sent while issue was closed. 
Patchset 5 (id:??) landed as
https://crrev.com/c3d7eb256bc0dd9d53b136ed8184cf54fdd4830e
Cr-Commit-Position: refs/heads/master@{#297245}

Powered by Google App Engine
This is Rietveld 408576698