Only inject ChromeVox classic when necessary.

Only inject ChromeVox classic when necessary.

TEST=Run chrome with and without the --enable-chromevox-next flag; observe injection occurs always for classic and only on non-whitelisted pages for next.

Committed: https://crrev.com/d89562aafd4c9ee7889dc1f0d7c485b758831957
Cr-Commit-Position: refs/heads/master@{#296744}

[David Tseng, 2014-09-24 18:50:57]

dtseng@chromium.org changed reviewers:
+ dmazzoni@chromium.org

[dmazzoni, 2014-09-24 19:12:15]

https://codereview.chromium.org/599193002/diff/1/chrome/browser/resources/chr...
File
chrome/browser/resources/chromeos/chromevox/chromevox/background/background.js
(right):

https://codereview.chromium.org/599193002/diff/1/chrome/browser/resources/chr...
chrome/browser/resources/chromeos/chromevox/chromevox/background/background.js:129:
self.injectChromeVoxIntoTabs(tabs);
is there supposed to be logic here that doesn't inject chromevox if it's a
chromevox next url?

https://codereview.chromium.org/599193002/diff/1/chrome/browser/resources/chr...
chrome/browser/resources/chromeos/chromevox/chromevox/background/background.js:157:
if (COMPILED || opt_forceCompiled) {
Do we even support an uncompiled mode anymore? My vote is to just kill it and
simplify the logic a lot.

We can still support a mode that merges everything into
chromeVoxChromePageScript.js but doesn't compile or remove whitespace, but it'd
still be merged into just one file.

https://codereview.chromium.org/599193002/diff/1/chrome/browser/resources/chr...
chrome/browser/resources/chromeos/chromevox/chromevox/background/background.js:546:
// Export this background page for ChromeVox next to access.
nit: ChromeVox next -> ChromeVox Next (capitalize Next so it looks like part of
the title)

[David Tseng, 2014-09-25 16:55:32]

https://codereview.chromium.org/599193002/diff/1/chrome/browser/resources/chr...
File
chrome/browser/resources/chromeos/chromevox/chromevox/background/background.js
(right):

https://codereview.chromium.org/599193002/diff/1/chrome/browser/resources/chr...
chrome/browser/resources/chromeos/chromevox/chromevox/background/background.js:129:
self.injectChromeVoxIntoTabs(tabs);
On 2014/09/24 19:12:15, dmazzoni wrote:
> is there supposed to be logic here that doesn't inject chromevox if it's a
> chromevox next url?

Done.

https://codereview.chromium.org/599193002/diff/1/chrome/browser/resources/chr...
chrome/browser/resources/chromeos/chromevox/chromevox/background/background.js:157:
if (COMPILED || opt_forceCompiled) {
On 2014/09/24 19:12:15, dmazzoni wrote:
> Do we even support an uncompiled mode anymore? My vote is to just kill it and
> simplify the logic a lot.
> 
> We can still support a mode that merges everything into
> chromeVoxChromePageScript.js but doesn't compile or remove whitespace, but
it'd
> still be merged into just one file.

We do; see the gyp option for compression.

https://codereview.chromium.org/599193002/diff/1/chrome/browser/resources/chr...
chrome/browser/resources/chromeos/chromevox/chromevox/background/background.js:546:
// Export this background page for ChromeVox next to access.
On 2014/09/24 19:12:15, dmazzoni wrote:
> nit: ChromeVox next -> ChromeVox Next (capitalize Next so it looks like part
of
> the title)
> 

Done.

[dmazzoni, 2014-09-25 17:02:13]

lgtm

[David Tseng, 2014-09-25 17:10:56]

The CQ bit was checked by dtseng@chromium.org

[commit-bot: I haz the power, 2014-09-25 17:11:50]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/599193002/20001

[commit-bot: I haz the power, 2014-09-25 18:12:55]

Committed patchset #2 (id:20001) as efb47d15edfc8df80ae91e8c8808ab6ab03bb94b

[commit-bot: I haz the power, 2014-09-25 18:13:59]

Patchset 2 (id:??) landed as
https://crrev.com/d89562aafd4c9ee7889dc1f0d7c485b758831957
Cr-Commit-Position: refs/heads/master@{#296744}