Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(233)

Issue 59913006: Roll swarming_client @ e98b112. (Closed)

Created:
7 years, 1 month ago by M-A Ruel
Modified:
7 years, 1 month ago
CC:
chromium-reviews, Paweł Hajdan Jr.
Visibility:
Public.

Description

Roll swarming_client @ e98b112. git log 141ef86..e98b112 --date=short --format="%ad %an %s" | sed 's/@chromium\.org//' 2013-11-05 Marc-Antoine Ruel Make licensecheck.pl happy by tweaking the license header. 2013-11-05 Marc-Antoine Ruel Update copyright to the Swarming Authors and codereview.settings. 2013-11-05 Marc-Antoine Ruel Update colorama to 5a3100113a3a. 2013-10-30 vadimsh Report all swarming and isolate fatal errors in a consistent way. 2013-10-28 csharp Set the Swarm Test encoding to UTF-8 This removes the need to blacklist colorama for license check. R=vadimsh@chromium.org,boliu@chromium.org BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=233524

Patch Set 1 #

Patch Set 2 : reroll #

Patch Set 3 : Also whitelist in webview #

Patch Set 4 : Updated the script directly #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M DEPS View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M android_webview/tools/webview_licenses.py View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
M-A Ruel
7 years, 1 month ago (2013-11-05 22:46:06 UTC) #1
Vadim Sh.
1) It looks like check_licenses doesn't like new swarming copyright?.. 2) Can we keep using ...
7 years, 1 month ago (2013-11-06 00:26:25 UTC) #2
M-A Ruel
On 2013/11/06 00:26:25, Vadim Sh. wrote: > 1) It looks like check_licenses doesn't like new ...
7 years, 1 month ago (2013-11-06 00:56:14 UTC) #3
M-A Ruel
Dropped the removal of the blacklist of colorama, since even with the new header it's ...
7 years, 1 month ago (2013-11-06 01:42:49 UTC) #4
M-A Ruel
ping
7 years, 1 month ago (2013-11-06 20:05:47 UTC) #5
M-A Ruel
Pawel, how do I get rid of: http://build.chromium.org/p/tryserver.chromium/builders/android_dbg/builds/120264/steps/check_licenses/logs/stdio The following files contain a third-party license ...
7 years, 1 month ago (2013-11-06 20:55:48 UTC) #6
Paweł Hajdan Jr.
See android_webview/tools/third_party_files_whitelist.txt
7 years, 1 month ago (2013-11-06 21:12:53 UTC) #7
M-A Ruel
Adding boliu@chromium.org for android_webview/tools/webview_licenses.py
7 years, 1 month ago (2013-11-06 22:18:05 UTC) #8
boliu
On 2013/11/06 22:18:05, M-A Ruel wrote: > Adding mailto:boliu@chromium.org for android_webview/tools/webview_licenses.py lgtm
7 years, 1 month ago (2013-11-06 22:22:15 UTC) #9
Vadim Sh.
lgtm
7 years, 1 month ago (2013-11-06 22:30:41 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/maruel@chromium.org/59913006/260001
7 years, 1 month ago (2013-11-06 23:12:59 UTC) #11
commit-bot: I haz the power
7 years, 1 month ago (2013-11-07 07:29:55 UTC) #12
Message was sent while issue was closed.
Change committed as 233524

Powered by Google App Engine
This is Rietveld 408576698