Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(231)

Issue 59913005: Remove unused TextTrack virtual functions (Closed)

Created:
7 years, 1 month ago by philipj_slow
Modified:
7 years, 1 month ago
Reviewers:
adamk, abarth-chromium
CC:
blink-reviews, jamesr, nessy, abarth-chromium, dglazkov+blink, adamk+blink_chromium.org, vcarbune.chromium
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Remove unused TextTrack virtual functions isClosedCaptions(), containsOnlyForcedSubtitles(), isMainProgramContent() and isEasyToRead() are unused. WebInbandTextTrack::isClosedCaptions() is implemented in Chromium (WebInbandTextTrackImpl) by switching on kind. Since it doesn't use OVERRIDE, it will still compile and can be removed after a Blink roll. BUG=315257 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=161398

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -62 lines) Patch
M Source/core/html/track/InbandTextTrack.h View 1 chunk +0 lines, -4 lines 0 comments Download
M Source/core/html/track/InbandTextTrack.cpp View 1 chunk +0 lines, -32 lines 0 comments Download
M Source/core/html/track/TextTrack.h View 1 chunk +0 lines, -6 lines 0 comments Download
M Source/core/html/track/TextTrack.cpp View 1 chunk +0 lines, -9 lines 0 comments Download
M Source/platform/graphics/media/InbandTextTrackPrivate.h View 1 chunk +0 lines, -4 lines 0 comments Download
M Source/web/InbandTextTrackPrivateImpl.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/web/InbandTextTrackPrivateImpl.cpp View 1 chunk +0 lines, -5 lines 0 comments Download
M public/web/WebInbandTextTrack.h View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 8 (0 generated)
philipj_slow
7 years, 1 month ago (2013-11-05 21:48:43 UTC) #1
adamk
lgtm
7 years, 1 month ago (2013-11-05 21:51:22 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/philipj@opera.com/59913005/1
7 years, 1 month ago (2013-11-05 22:16:24 UTC) #3
commit-bot: I haz the power
Retried try job too often on blink_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=blink_presubmit&number=10644
7 years, 1 month ago (2013-11-05 22:35:12 UTC) #4
philipj_slow
Looks like I need an LGTM on public/web/WebInbandTextTrack.h as well.
7 years, 1 month ago (2013-11-05 22:37:01 UTC) #5
abarth-chromium
public <--- LGTM
7 years, 1 month ago (2013-11-05 22:39:14 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/philipj@opera.com/59913005/1
7 years, 1 month ago (2013-11-05 22:39:52 UTC) #7
commit-bot: I haz the power
7 years, 1 month ago (2013-11-06 00:03:40 UTC) #8
Message was sent while issue was closed.
Change committed as 161398

Powered by Google App Engine
This is Rietveld 408576698