Issue 59913004: Fixed logging for network portal detector.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 59913004: Fixed logging for network portal detector. (Closed)

Created:
7 years, 1 month ago by ygorshenin1

Modified:
7 years, 1 month ago

Reviewers:
Nikita (slow)

CC:
chromium-reviews, cbentzel+watch_chromium.org, nkostylev+watch_chromium.org, gauravsh+watch_chromium.org, oshima+watch_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Fixed logging for network portal detector. BUG=315054 TEST=manual tests on Lumpy Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=233261

Patch Set 1 #

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+29 lines, -37 lines)			Patch
M	chrome/app/chromeos_strings.grdp	View	1 chunk	+0 lines, -20 lines	0 comments	Download
M	chrome/browser/chromeos/net/network_portal_detector_impl.h	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	chrome/browser/chromeos/net/network_portal_detector_impl.cc	View	7 chunks	+26 lines, -17 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ygorshenin@chromium.org/59913004/1

7 years, 1 month ago (2013-11-05 14:57:02 UTC) #3

commit-bot: I haz the power

Retried try job too often on win_rel for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=219654

7 years, 1 month ago (2013-11-05 16:28:34 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ygorshenin@chromium.org/59913004/1

7 years, 1 month ago (2013-11-06 10:45:57 UTC) #5

Message was sent while issue was closed.

Change committed as 233261

Expand Messages | Collapse Messages