Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issue 59913003: Ensure that typed array constructors are crankshaftable. (Closed)

Created:
7 years, 1 month ago by Dmitry Lomov (no reviews)
Modified:
7 years, 1 month ago
Reviewers:
Yang
CC:
v8-dev
Visibility:
Public.

Description

Ensure that typed array constructors are crankshaftable. Also, do not allocate sub-closures for every call to typed array constructor. R=yangguo@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=17528

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -46 lines) Patch
M src/typedarray.js View 2 chunks +46 lines, -46 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Dmitry Lomov (no reviews)
PTAL.
7 years, 1 month ago (2013-11-05 14:20:26 UTC) #1
Yang
On 2013/11/05 14:20:26, Dmitry Lomov (chromium) wrote: > PTAL. LGTM. But not sure why this ...
7 years, 1 month ago (2013-11-06 15:40:52 UTC) #2
Dmitry Lomov (no reviews)
On 2013/11/06 15:40:52, Yang wrote: > On 2013/11/05 14:20:26, Dmitry Lomov (chromium) wrote: > > ...
7 years, 1 month ago (2013-11-06 16:10:16 UTC) #3
Dmitry Lomov (no reviews)
7 years, 1 month ago (2013-11-06 16:28:43 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 manually as r17528 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698