Insert materialized context at the right place in DebugEvaluate.

Insert materialized context at the right place in DebugEvaluate.


R=aandrey@chromium.org, ulan@chromium.org
BUG=chromium:323936
LOG=N

Committed: https://code.google.com/p/v8/source/detail?r=24218

[aandrey, 2014-09-25 06:19:06]

lgtm

https://codereview.chromium.org/599113002/diff/1/src/runtime.cc
File src/runtime.cc (right):

https://codereview.chromium.org/599113002/diff/1/src/runtime.cc#newcode13112
src/runtime.cc:13112:
inner_context->set_previous(materialized_context->previous());
nit: inner_context->set_previous(function_context); ?

https://codereview.chromium.org/599113002/diff/1/test/mjsunit/regress/regress...
File test/mjsunit/regress/regress-crbug-323936.js (right):

https://codereview.chromium.org/599113002/diff/1/test/mjsunit/regress/regress...
test/mjsunit/regress/regress-crbug-323936.js:17: exec_state.frame(0).evaluate("e
= 'foo'");
Below is the check that changes above materialized_context gets written back.

exec_state.frame(0).evaluate("x = 'modified'");

https://codereview.chromium.org/599113002/diff/1/test/mjsunit/regress/regress...
test/mjsunit/regress/regress-crbug-323936.js:31: function f(e) {
f(e, x)

https://codereview.chromium.org/599113002/diff/1/test/mjsunit/regress/regress...
test/mjsunit/regress/regress-crbug-323936.js:39: assertEquals("bar", e);
assertEquals("modified", x);

[Yang, 2014-09-25 07:47:07]

On 2014/09/25 06:19:06, aandrey wrote:
> lgtm
> 
> https://codereview.chromium.org/599113002/diff/1/src/runtime.cc
> File src/runtime.cc (right):
> 
> https://codereview.chromium.org/599113002/diff/1/src/runtime.cc#newcode13112
> src/runtime.cc:13112:
> inner_context->set_previous(materialized_context->previous());
> nit: inner_context->set_previous(function_context); ?
> 
>
https://codereview.chromium.org/599113002/diff/1/test/mjsunit/regress/regress...
> File test/mjsunit/regress/regress-crbug-323936.js (right):
> 
>
https://codereview.chromium.org/599113002/diff/1/test/mjsunit/regress/regress...
> test/mjsunit/regress/regress-crbug-323936.js:17:
exec_state.frame(0).evaluate("e
> = 'foo'");
> Below is the check that changes above materialized_context gets written back.
> 
> exec_state.frame(0).evaluate("x = 'modified'");
> 
>
https://codereview.chromium.org/599113002/diff/1/test/mjsunit/regress/regress...
> test/mjsunit/regress/regress-crbug-323936.js:31: function f(e) {
> f(e, x)
> 
>
https://codereview.chromium.org/599113002/diff/1/test/mjsunit/regress/regress...
> test/mjsunit/regress/regress-crbug-323936.js:39: assertEquals("bar", e);
> assertEquals("modified", x);

addressed comment.

[ulan, 2014-09-25 09:22:46]

lgtm

[Yang, 2014-09-25 09:33:49]

Committed patchset #3 (id:40001) manually as 24218 (tree was closed).