Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(267)

Issue 599103006: Enabling audio quality test on mac. (Closed)

Created:
6 years, 2 months ago by phoglund_chromium
Modified:
6 years, 2 months ago
CC:
chromium-reviews, posciak+watch_chromium.org, feature-media-reviews_chromium.org, wjia+watch_chromium.org, mcasas+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Enabling audio quality test on mac. Note: will land on Monday; need to watch bots so that they execute the test right. TBR=vrk@chromium.org BUG=418034 Committed: https://crrev.com/c4e4aaaf43c0da2a01c0f32be737dcbbd5f13e92 Cr-Commit-Position: refs/heads/master@{#297166}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M chrome/browser/media/chrome_webrtc_audio_quality_browsertest.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (1 generated)
phoglund_chromium
Just preparing this CL for next week. I've configured all bots (I think) and plan ...
6 years, 2 months ago (2014-09-26 14:33:37 UTC) #1
phoglund_chromium
On 2014/09/26 14:33:37, phoglund wrote: > Just preparing this CL for next week. I've configured ...
6 years, 2 months ago (2014-09-29 11:44:21 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/599103006/1
6 years, 2 months ago (2014-09-29 11:44:40 UTC) #4
vrk (LEFT CHROMIUM)
lgtm
6 years, 2 months ago (2014-09-29 12:09:01 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as 94eb95c8a2bc5cd9a5ac6e75674c51bae11f71e5
6 years, 2 months ago (2014-09-29 13:41:48 UTC) #6
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/c4e4aaaf43c0da2a01c0f32be737dcbbd5f13e92 Cr-Commit-Position: refs/heads/master@{#297166}
6 years, 2 months ago (2014-09-29 13:42:23 UTC) #7
phoglund_chromium
6 years, 2 months ago (2014-09-29 21:01:31 UTC) #8
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/613833002/ by phoglund@chromium.org.

The reason for reverting is: There is one stubborn bot that is unreachable from
VNC; reverting until we can sort that out..

Powered by Google App Engine
This is Rietveld 408576698