Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(89)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 599103005: Make sure m_usePathFallback is always updated when updating shape (Closed)

Created:
6 years, 2 months ago by fs
Modified:
6 years, 2 months ago
Reviewers:
pdr., f(malita)
CC:
blink-reviews, blink-reviews-rendering, zoltan1, rwlbuis, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, kouhei+svg_chromium.org, fs, ed+blinkwatch_opera.com, krit, f(malita), gyuyoung.kim_webkit.org, jchaffraix+rendering, Stephen Chennney, pdr+svgwatchlist_chromium.org, rune+blink
Project:
blink
Visibility:
Public.

Description

Make sure m_usePathFallback is always updated when updating shape When mutating a shape such that it would change from using the fallback to _not_ using the fallback, the |m_usePathFallback| flag was not updated to reflect this, mean that the shape could/would still be painted. BUG=417454 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=182770

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -2 lines) Patch
A LayoutTests/svg/custom/circle-update-to-empty.html View 1 chunk +18 lines, -0 lines 0 comments Download
A LayoutTests/svg/custom/circle-update-to-empty-expected.html View 1 chunk +2 lines, -0 lines 0 comments Download
A LayoutTests/svg/custom/rounded-rect-update-to-empty.html View 1 chunk +19 lines, -0 lines 0 comments Download
A LayoutTests/svg/custom/rounded-rect-update-to-empty-expected.html View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/rendering/svg/RenderSVGEllipse.cpp View 2 chunks +1 line, -1 line 0 comments Download
M Source/core/rendering/svg/RenderSVGRect.cpp View 2 chunks +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
fs
Seems these methods can't catch a break...
6 years, 2 months ago (2014-09-26 13:43:37 UTC) #2
f(malita)
lgtm
6 years, 2 months ago (2014-09-26 13:54:01 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/599103005/1
6 years, 2 months ago (2014-09-26 13:54:25 UTC) #5
commit-bot: I haz the power
6 years, 2 months ago (2014-09-26 14:43:20 UTC) #6
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as 182770

Powered by Google App Engine
This is Rietveld 408576698