Provide a small amount of padding in extension errors for the highlight border

Provide a small amount of padding in extension errors for the highlight border

Since extension errors are designed to take up the full amount of space, there
was no room left for the borders to indicate tab highlighting, and they were
slightly cut off. Fix this by adding a tiny bit of room above and below each
error, and to the end of the view details link.

Screenshots (after and before): http://imgur.com/acdRaXH,XDDIdZ8
BUG=380637
Committed: https://crrev.com/6706d602df4b4ce4d4df211a8771965c4b6db145
Cr-Commit-Position: refs/heads/master@{#297092}

[Devlin, 2014-09-25 17:34:26]

rdevlin.cronin@chromium.org changed reviewers:
+ dbeam@chromium.org

[Devlin, 2014-09-25 17:34:26]

Mind taking a look, Dan?

[Dan Beam, 2014-09-26 01:42:20]

lgtm

https://codereview.chromium.org/599103004/diff/1/chrome/browser/resources/ext...
File chrome/browser/resources/extensions/extension_error.css (right):

https://codereview.chromium.org/599103004/diff/1/chrome/browser/resources/ext...
chrome/browser/resources/extensions/extension_error.css:49:
-webkit-margin-before: 1px;
why not margin-(bottom|top)?

[Devlin, 2014-09-27 00:33:24]

https://codereview.chromium.org/599103004/diff/1/chrome/browser/resources/ext...
File chrome/browser/resources/extensions/extension_error.css (right):

https://codereview.chromium.org/599103004/diff/1/chrome/browser/resources/ext...
chrome/browser/resources/extensions/extension_error.css:49:
-webkit-margin-before: 1px;
On 2014/09/26 01:42:19, Dan Beam wrote:
> why not margin-(bottom|top)?

I thought the -webkit variants were encouraged for these (even for bottom and
top).  For my own edification, is there a time when we prefer one of these over
the other (excluding the obvious case of preferring start/end for most things
due to LTR vs RTL distinctions)?

(And changed to margin-bottom\top).

[Devlin, 2014-09-27 00:33:27]

The CQ bit was checked by rdevlin.cronin@chromium.org

[commit-bot: I haz the power, 2014-09-27 00:34:38]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/599103004/20001

[Dan Beam, 2014-09-27 01:27:41]

slgtm

https://codereview.chromium.org/599103004/diff/1/chrome/browser/resources/ext...
File chrome/browser/resources/extensions/extension_error.css (right):

https://codereview.chromium.org/599103004/diff/1/chrome/browser/resources/ext...
chrome/browser/resources/extensions/extension_error.css:49:
-webkit-margin-before: 1px;
On 2014/09/27 00:33:24, Devlin wrote:
> On 2014/09/26 01:42:19, Dan Beam wrote:
> > why not margin-(bottom|top)?
> 
> I thought the -webkit variants were encouraged for these (even for bottom and
> top).  For my own edification, is there a time when we prefer one of these
over
> the other (excluding the obvious case of preferring start/end for most things
> due to LTR vs RTL distinctions)?
> 
> (And changed to margin-bottom\top).

start/end have some useful properties for LTR/RTL.  before/after aren't as clear
to me as top/bottom, imo, and sound like ::before/::after...

[commit-bot: I haz the power, 2014-09-27 01:51:20]

Committed patchset #2 (id:20001) as d4785d8ed61aa9d7149a76c85c595207b21dbd85

[commit-bot: I haz the power, 2014-09-27 01:51:51]

Patchset 2 (id:??) landed as
https://crrev.com/6706d602df4b4ce4d4df211a8771965c4b6db145
Cr-Commit-Position: refs/heads/master@{#297092}