Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Issue 599103003: Switch from WebMediaPlayer::maxTimeSeekable() to seekable() (Closed)

Created:
6 years, 2 months ago by philipj_slow
Modified:
6 years, 2 months ago
CC:
chromium-reviews, posciak+watch_chromium.org, avayvod+watch_chromium.org, jam, mcasas+watch_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, mkwst+moarreviews-renderer_chromium.org, wjia+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Switch from WebMediaPlayer::maxTimeSeekable() to seekable() BUG=417669 Committed: https://crrev.com/b0e6f3fce92c7e2cc3df4a1d10d5508a48d1febc Cr-Commit-Position: refs/heads/master@{#297395}

Patch Set 1 #

Total comments: 6

Patch Set 2 : early return #

Total comments: 6

Patch Set 3 : no this-> or static_cast<size_t> #

Patch Set 4 : compile on android #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -18 lines) Patch
M content/renderer/media/android/webmediaplayer_android.h View 1 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/media/android/webmediaplayer_android.cc View 1 2 3 2 chunks +12 lines, -7 lines 0 comments Download
M content/renderer/media/webmediaplayer_ms.h View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/media/webmediaplayer_ms.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M media/blink/webmediaplayer_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M media/blink/webmediaplayer_impl.cc View 1 2 1 chunk +13 lines, -6 lines 0 comments Download

Messages

Total messages: 21 (4 generated)
philipj_slow
PTAL. No need to be gentle, I know this is a bit ugly, I was ...
6 years, 2 months ago (2014-09-26 07:44:58 UTC) #2
scherkus (not reviewing)
lgtm w/ question about interval notation because it's been a while since I've had to ...
6 years, 2 months ago (2014-09-26 18:53:28 UTC) #3
philipj_slow
All that's needed to land these patches is platform review on the first patch. If ...
6 years, 2 months ago (2014-09-26 20:32:02 UTC) #4
DaleCurtis
lgtm https://codereview.chromium.org/599103003/diff/1/content/renderer/media/android/webmediaplayer_android.cc File content/renderer/media/android/webmediaplayer_android.cc (right): https://codereview.chromium.org/599103003/diff/1/content/renderer/media/android/webmediaplayer_android.cc#newcode518 content/renderer/media/android/webmediaplayer_android.cc:518: WDYT about reordering slightly so that: const double ...
6 years, 2 months ago (2014-09-26 20:45:24 UTC) #5
philipj_slow
early return
6 years, 2 months ago (2014-09-29 09:33:31 UTC) #6
philipj_slow
https://codereview.chromium.org/599103003/diff/1/content/renderer/media/android/webmediaplayer_android.cc File content/renderer/media/android/webmediaplayer_android.cc (right): https://codereview.chromium.org/599103003/diff/1/content/renderer/media/android/webmediaplayer_android.cc#newcode518 content/renderer/media/android/webmediaplayer_android.cc:518: On 2014/09/26 20:45:24, DaleCurtis wrote: > WDYT about reordering ...
6 years, 2 months ago (2014-09-29 09:33:44 UTC) #7
DaleCurtis
https://codereview.chromium.org/599103003/diff/20001/content/renderer/media/android/webmediaplayer_android.cc File content/renderer/media/android/webmediaplayer_android.cc (right): https://codereview.chromium.org/599103003/diff/20001/content/renderer/media/android/webmediaplayer_android.cc#newcode530 content/renderer/media/android/webmediaplayer_android.cc:530: const double duration = this->duration(); Avoid this-> with current_duration ...
6 years, 2 months ago (2014-09-29 16:52:44 UTC) #8
philipj_slow
https://codereview.chromium.org/599103003/diff/20001/content/renderer/media/android/webmediaplayer_android.cc File content/renderer/media/android/webmediaplayer_android.cc (right): https://codereview.chromium.org/599103003/diff/20001/content/renderer/media/android/webmediaplayer_android.cc#newcode530 content/renderer/media/android/webmediaplayer_android.cc:530: const double duration = this->duration(); On 2014/09/29 16:52:43, DaleCurtis ...
6 years, 2 months ago (2014-09-29 19:51:46 UTC) #9
philipj_slow
no this-> or static_cast<size_t>
6 years, 2 months ago (2014-09-30 08:07:48 UTC) #10
philipj_slow
I'll go ahead and land this. As always, if anything is unpalatable don't hesitate to ...
6 years, 2 months ago (2014-09-30 08:09:29 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/599103003/40001
6 years, 2 months ago (2014-09-30 08:10:53 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_dbg_recipe on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_arm64_dbg_recipe/builds/8501) android_dbg_tests_recipe on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_dbg_tests_recipe/builds/13713)
6 years, 2 months ago (2014-09-30 08:28:07 UTC) #15
philipj_slow
compile on android
6 years, 2 months ago (2014-09-30 08:53:23 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/599103003/60001
6 years, 2 months ago (2014-09-30 08:54:14 UTC) #18
commit-bot: I haz the power
Committed patchset #4 (id:60001) as 27726d24b7e455b1c887978cfb4aa2e5e341bda3
6 years, 2 months ago (2014-09-30 09:52:01 UTC) #19
commit-bot: I haz the power
Patchset 4 (id:??) landed as https://crrev.com/b0e6f3fce92c7e2cc3df4a1d10d5508a48d1febc Cr-Commit-Position: refs/heads/master@{#297395}
6 years, 2 months ago (2014-09-30 09:52:50 UTC) #20
DaleCurtis
6 years, 2 months ago (2014-09-30 17:22:34 UTC) #21
Message was sent while issue was closed.
still lgtm, thanks!

Powered by Google App Engine
This is Rietveld 408576698