Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(119)

Issue 599093005: [Android] Insert chromium version string into native libraries. (Closed)

Created:
6 years, 2 months ago by Feng Qian
Modified:
6 years, 2 months ago
CC:
chromium-reviews, klundberg+watch_chromium.org, yfriedman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

[Android] Insert chromium version string into native libraries. When building the native libraries, insert the version string into native libraries as a section .chromium.verson. BUG=417510 Committed: https://crrev.com/29d1208bfd30add739982738a6f11f7b0dbcfcd0 Cr-Commit-Position: refs/heads/master@{#297065}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+99 lines, -20 lines) Patch
A build/android/gyp/insert_chromium_version.py View 1 chunk +66 lines, -0 lines 0 comments Download
A + build/android/insert_chromium_version.gypi View 2 chunks +17 lines, -18 lines 0 comments Download
M build/java_apk.gypi View 4 chunks +16 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
Feng Qian
6 years, 2 months ago (2014-09-24 23:45:11 UTC) #2
Feng Qian
Does objcopy add-section work for x86? I guess it only works on Linux ELF format, ...
6 years, 2 months ago (2014-09-24 23:46:02 UTC) #3
simonb (inactive)
On 2014/09/24 23:46:02, Feng Qian wrote: > Does objcopy add-section work for x86? I guess ...
6 years, 2 months ago (2014-09-26 11:13:06 UTC) #4
simonb (inactive)
lgtm
6 years, 2 months ago (2014-09-26 11:20:49 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/599093005/1
6 years, 2 months ago (2014-09-26 22:25:25 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1) as 6321feaabf965f83c73284397089379b60fc4762
6 years, 2 months ago (2014-09-26 23:22:57 UTC) #8
commit-bot: I haz the power
6 years, 2 months ago (2014-09-26 23:23:37 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/29d1208bfd30add739982738a6f11f7b0dbcfcd0
Cr-Commit-Position: refs/heads/master@{#297065}

Powered by Google App Engine
This is Rietveld 408576698