Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1080)

Unified Diff: chrome/browser/extensions/external_component_loader.cc

Issue 599053004: Replace placeholder extension ID for hotwording shared module with ID of module uploaded to the Chr… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix HotwordService::IsServiceAvailable(). Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/resources/hotword/constants.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/extensions/external_component_loader.cc
diff --git a/chrome/browser/extensions/external_component_loader.cc b/chrome/browser/extensions/external_component_loader.cc
index efdd2964d7ea60b72a6be62429061929e6b73e64..80fa5580a1a01c9e9db8254de7c01f663b837c65 100644
--- a/chrome/browser/extensions/external_component_loader.cc
+++ b/chrome/browser/extensions/external_component_loader.cc
@@ -50,12 +50,11 @@ void ExternalComponentLoader::StartLoading() {
if (HotwordServiceFactory::IsHotwordAllowed(profile_)) {
std::string hotwordId = extension_misc::kHotwordExtensionId;
CommandLine* command_line = CommandLine::ForCurrentProcess();
- // TODO(amistry): Load the hotword shared module when enabling built-in
- // hotword detection.
- if (!command_line->HasSwitch(switches::kEnableExperimentalHotwording)) {
- prefs_->SetString(hotwordId + ".external_update_url",
- extension_urls::GetWebstoreUpdateUrl().spec());
+ if (command_line->HasSwitch(switches::kEnableExperimentalHotwording)) {
+ hotwordId = extension_misc::kHotwordSharedModuleId;
}
+ prefs_->SetString(hotwordId + ".external_update_url",
+ extension_urls::GetWebstoreUpdateUrl().spec());
}
InitBookmarksExperimentState(profile_);
« no previous file with comments | « no previous file | chrome/browser/resources/hotword/constants.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698