Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(242)

Issue 599053004: Replace placeholder extension ID for hotwording shared module with ID of module uploaded to the Chr… (Closed)

Created:
6 years, 3 months ago by Anand Mistry (off Chromium)
Modified:
6 years, 2 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, rlp+watch_chromium.org, arv+watch_chromium.org, extensions-reviews_chromium.org, chrome-apps-syd-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Replace placeholder extension ID for hotwording shared module with ID of module uploaded to the Chrome web store. Also, auto-install hotword shared module when hotwording is enabled. BUG=397019 Committed: https://crrev.com/075d1694c7f5594a923bb6275cbbd21f0cfa2441 Cr-Commit-Position: refs/heads/master@{#296890}

Patch Set 1 #

Patch Set 2 : Fix HotwordService::IsServiceAvailable(). #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -12 lines) Patch
M chrome/browser/extensions/external_component_loader.cc View 1 chunk +4 lines, -5 lines 0 comments Download
M chrome/browser/resources/hotword/constants.js View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/resources/hotword/manifest.json View 1 chunk +1 line, -4 lines 0 comments Download
M chrome/browser/search/hotword_service.cc View 1 1 chunk +9 lines, -1 line 0 comments Download
M chrome/common/extensions/extension_constants.h View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/common/extensions/extension_constants.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Anand Mistry (off Chromium)
6 years, 3 months ago (2014-09-25 02:57:03 UTC) #2
James Hawkins
lgtm
6 years, 2 months ago (2014-09-25 18:02:10 UTC) #3
rpetterson
lgtm
6 years, 2 months ago (2014-09-26 03:53:13 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/599053004/20001
6 years, 2 months ago (2014-09-26 03:58:49 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001) as 8c3dc46b04706b2858bea0bf8fc198d97b303bbc
6 years, 2 months ago (2014-09-26 05:33:41 UTC) #7
commit-bot: I haz the power
6 years, 2 months ago (2014-09-26 05:34:16 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/075d1694c7f5594a923bb6275cbbd21f0cfa2441
Cr-Commit-Position: refs/heads/master@{#296890}

Powered by Google App Engine
This is Rietveld 408576698