Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(545)

Issue 59903023: Plumb maxTouchPoints for AuraX11 (Closed)

Created:
7 years, 1 month ago by Yufeng Shen (Slow to review)
Modified:
7 years, 1 month ago
Reviewers:
sadrul
CC:
chromium-reviews
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Plumb maxTouchPoints for AuraX11 Aura implementation for navigator.maxTouchPoints defined in the W3C Pointer Events standard draft: http://www.w3.org/TR/pointerevents/#widl-Navigator-maxTouchPoints BUG=312926 TEST=navigator.maxTouchPoints shows 16 on Pixel. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=235528

Patch Set 1 #

Total comments: 2

Patch Set 2 : rename MaxTouchPoints() to GetMaxTouchPoints() #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -3 lines) Patch
M ui/base/touch/touch_device_aurax11.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M ui/events/x/touch_factory_x11.h View 1 2 chunks +8 lines, -2 lines 0 comments Download
M ui/events/x/touch_factory_x11.cc View 1 4 chunks +8 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
Yufeng Shen (Slow to review)
7 years, 1 month ago (2013-11-14 00:03:15 UTC) #1
Yufeng Shen (Slow to review)
Ping. Sadrul: mind giving a quick look ? it's a pretty simple change.
7 years, 1 month ago (2013-11-15 19:41:38 UTC) #2
sadrul
LGTM. Sorry about the delay. https://codereview.chromium.org/59903023/diff/1/ui/events/x/touch_factory_x11.h File ui/events/x/touch_factory_x11.h (right): https://codereview.chromium.org/59903023/diff/1/ui/events/x/touch_factory_x11.h#newcode76 ui/events/x/touch_factory_x11.h:76: int MaxTouchPoints(); GetMaxTouchPoints() const
7 years, 1 month ago (2013-11-15 19:48:52 UTC) #3
Yufeng Shen (Slow to review)
https://codereview.chromium.org/59903023/diff/1/ui/events/x/touch_factory_x11.h File ui/events/x/touch_factory_x11.h (right): https://codereview.chromium.org/59903023/diff/1/ui/events/x/touch_factory_x11.h#newcode76 ui/events/x/touch_factory_x11.h:76: int MaxTouchPoints(); On 2013/11/15 19:48:53, sadrul wrote: > GetMaxTouchPoints() ...
7 years, 1 month ago (2013-11-15 19:57:56 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/miletus@chromium.org/59903023/70001
7 years, 1 month ago (2013-11-15 20:05:40 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/miletus@chromium.org/59903023/70001
7 years, 1 month ago (2013-11-15 21:51:48 UTC) #6
Rick Byers
On 2013/11/15 21:51:48, I haz the power (commit-bot) wrote: > CQ is trying da patch. ...
7 years, 1 month ago (2013-11-15 22:18:05 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/miletus@chromium.org/59903023/70001
7 years, 1 month ago (2013-11-16 00:19:46 UTC) #8
commit-bot: I haz the power
7 years, 1 month ago (2013-11-17 16:03:21 UTC) #9
Message was sent while issue was closed.
Change committed as 235528

Powered by Google App Engine
This is Rietveld 408576698