Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 59903019: Moved SimplifyDocumentTitle from printing/backend (Closed)

Created:
7 years, 1 month ago by Vitaly Buka (NO REVIEWS)
Modified:
7 years, 1 month ago
Reviewers:
Noam Samuel, gene
CC:
chromium-reviews
Visibility:
Public.

Description

Moved SimplifyDocumentTitle from printing/backend TBR=noamsml Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=234127

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+78 lines, -77 lines) Patch
M chrome/browser/printing/print_job_worker.cc View 1 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/service/cloud_print/print_system_win.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/service/cloud_print/printer_job_handler.cc View 2 chunks +3 lines, -4 lines 0 comments Download
M printing/backend/print_backend.h View 2 chunks +0 lines, -4 lines 0 comments Download
M printing/backend/print_backend.cc View 2 chunks +0 lines, -18 lines 0 comments Download
D printing/backend/print_backend_unittest.cc View 1 2 3 1 chunk +0 lines, -26 lines 0 comments Download
M printing/printing.gyp View 1 2 3 4 chunks +17 lines, -15 lines 0 comments Download
M printing/printing_context_win.cc View 2 chunks +2 lines, -1 line 0 comments Download
A printing/printing_utils.h View 1 2 1 chunk +19 lines, -0 lines 0 comments Download
A printing/printing_utils.cc View 1 2 1 chunk +28 lines, -0 lines 0 comments Download
A + printing/printing_utils_unittest.cc View 1 2 3 1 chunk +4 lines, -4 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vitalybuka@chromium.org/59903019/30001
7 years, 1 month ago (2013-11-09 03:02:36 UTC) #1
commit-bot: I haz the power
Retried try job too often on linux_rel for step(s) base_unittests, browser_tests, cacheinvalidation_unittests, cc_unittests, check_deps, chromedriver2_unittests, ...
7 years, 1 month ago (2013-11-09 03:15:01 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vitalybuka@chromium.org/59903019/30001
7 years, 1 month ago (2013-11-09 03:58:27 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vitalybuka@chromium.org/59903019/320001
7 years, 1 month ago (2013-11-09 04:00:04 UTC) #4
commit-bot: I haz the power
Retried try job too often on linux_rel for step(s) base_unittests, browser_tests, interactive_ui_tests, net_unittests, unit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&number=187681
7 years, 1 month ago (2013-11-09 04:15:24 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vitalybuka@chromium.org/59903019/410002
7 years, 1 month ago (2013-11-09 04:24:16 UTC) #6
commit-bot: I haz the power
Step "update" is always a major failure. Look at the try server FAQ for more ...
7 years, 1 month ago (2013-11-09 04:31:36 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vitalybuka@chromium.org/59903019/410002
7 years, 1 month ago (2013-11-09 06:44:02 UTC) #8
commit-bot: I haz the power
Change committed as 234127
7 years, 1 month ago (2013-11-09 17:24:32 UTC) #9
gene
lgtm
7 years, 1 month ago (2013-11-09 19:01:50 UTC) #10
Noam Samuel
7 years, 1 month ago (2013-11-12 18:20:27 UTC) #11
Message was sent while issue was closed. 
lgtm

Powered by Google App Engine
This is Rietveld 408576698