Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(323)

Issue 59903015: [Shadow DOM]: Empty shadow insertion points should behave like <shadow><content *leftover*></conten… (Closed)

Created:
7 years, 1 month ago by hayato
Modified:
7 years, 1 month ago
Reviewers:
esprehn, dglazkov
CC:
blink-reviews, webcomponents-bugzilla_chromium.org, dglazkov+blink, eae+blinkwatch, adamk+blink_chromium.org
Visibility:
Public.

Description

[Shadow DOM]: Empty shadow insertion points should behave like <shadow><content *leftover*></content></shadow> This is a follow up patch for r161137. We've changed the spec so that we keep a backward compatibility for empty shadow insertion points. The spec side issue is https://www.w3.org/Bugs/Public/show_bug.cgi?id=23767 BUG=316513 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=161702

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+91 lines, -47 lines) Patch
A + LayoutTests/fast/dom/shadow/event-path-empty-shadow-element.html View 1 chunk +5 lines, -3 lines 0 comments Download
A + LayoutTests/fast/dom/shadow/event-path-empty-shadow-element-expected.txt View 2 chunks +9 lines, -6 lines 0 comments Download
M LayoutTests/fast/dom/shadow/resources/event-dispatching.js View 1 chunk +10 lines, -0 lines 0 comments Download
A + LayoutTests/fast/dom/shadow/shadow-dom-event-dispatching-empty-shadow-element.html View 1 chunk +4 lines, -3 lines 0 comments Download
A + LayoutTests/fast/dom/shadow/shadow-dom-event-dispatching-empty-shadow-element-expected.txt View 2 chunks +10 lines, -1 line 0 comments Download
M LayoutTests/fast/dom/shadow/shadow-element-distributed-nodes.html View 3 chunks +3 lines, -3 lines 0 comments Download
M LayoutTests/fast/dom/shadow/shadow-element-distributed-nodes-expected.txt View 2 chunks +4 lines, -2 lines 0 comments Download
M LayoutTests/fast/dom/shadow/shadow-insertion-point-rendering-expected.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/dom/shadow/shadow-insertion-point-rendering-multiple-shadow-roots-expected.html View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/shadow/ElementShadow.cpp View 5 chunks +26 lines, -16 lines 0 comments Download
M Source/core/events/EventPath.cpp View 2 chunks +18 lines, -11 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
hayato
PTAL
7 years, 1 month ago (2013-11-08 06:22:53 UTC) #1
dglazkov
lgtm
7 years, 1 month ago (2013-11-08 18:08:39 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hayato@chromium.org/59903015/1
7 years, 1 month ago (2013-11-11 00:43:05 UTC) #3
commit-bot: I haz the power
7 years, 1 month ago (2013-11-11 01:29:06 UTC) #4
Message was sent while issue was closed.
Change committed as 161702

Powered by Google App Engine
This is Rietveld 408576698