Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(169)

Unified Diff: chrome/browser/ui/webui/ntp/thumbnail_source.h

Issue 59903010: Ensure using chrome://thumb2/... adds the URL as a forced URL in TopSites so that a thumbnail is ca… (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Completed with unit test. Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/ntp/thumbnail_source.h
diff --git a/chrome/browser/ui/webui/ntp/thumbnail_source.h b/chrome/browser/ui/webui/ntp/thumbnail_source.h
index f4ff8f014388f4cc9752889265219f08650ed7c4..c280c4cb219b5b0db3bd25a004b7e12fb74b377a 100644
--- a/chrome/browser/ui/webui/ntp/thumbnail_source.h
+++ b/chrome/browser/ui/webui/ntp/thumbnail_source.h
@@ -25,7 +25,7 @@ class ThumbnailService;
// thumbnails and the history/top-sites backend that serves these.
class ThumbnailSource : public content::URLDataSource {
public:
- ThumbnailSource(Profile* profile, bool prefix_match);
+ ThumbnailSource(Profile* profile, bool forced_thumbnails);
// content::URLDataSource implementation.
virtual std::string GetSource() const OVERRIDE;
@@ -53,10 +53,11 @@ class ThumbnailSource : public content::URLDataSource {
// Only used when servicing requests on the UI thread.
Profile* const profile_;
- // If an exact thumbnail URL match fails, specifies whether or not to try
- // harder by matching the query thumbnail URL as URL prefix. This affects
- // GetSource().
- const bool prefix_match_;
+ // Indicate that this source will force the eventual capture of requested URLs
Evan Stade 2013/11/20 22:32:36 I can't understand this comment. Can you rewrite i
beaudoin 2013/11/21 00:06:46 You're right, it's a bit opaque. Is the new one be
+ // if they are not found. Such a source will also be more lenient when
+ // matching thumbnail URL, by checking for existing thumbnails in the database
+ // that contain URL matching the prefix of the requested URL.
+ const bool forced_thumbnails_;
DISALLOW_COPY_AND_ASSIGN(ThumbnailSource);
};

Powered by Google App Engine
This is Rietveld 408576698