Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1059)

Unified Diff: chrome/browser/ui/webui/ntp/thumbnail_source.h

Issue 59903010: Ensure using chrome://thumb2/... adds the URL as a forced URL in TopSites so that a thumbnail is ca… (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Take 2. Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/ntp/thumbnail_source.h
diff --git a/chrome/browser/ui/webui/ntp/thumbnail_source.h b/chrome/browser/ui/webui/ntp/thumbnail_source.h
index f4ff8f014388f4cc9752889265219f08650ed7c4..167dffaa8898cc085ad63f935044b194f415a65e 100644
--- a/chrome/browser/ui/webui/ntp/thumbnail_source.h
+++ b/chrome/browser/ui/webui/ntp/thumbnail_source.h
@@ -25,7 +25,7 @@ class ThumbnailService;
// thumbnails and the history/top-sites backend that serves these.
class ThumbnailSource : public content::URLDataSource {
public:
- ThumbnailSource(Profile* profile, bool prefix_match);
+ ThumbnailSource(Profile* profile, bool capture_thumbnails);
// content::URLDataSource implementation.
virtual std::string GetSource() const OVERRIDE;
@@ -53,10 +53,15 @@ class ThumbnailSource : public content::URLDataSource {
// Only used when servicing requests on the UI thread.
Profile* const profile_;
- // If an exact thumbnail URL match fails, specifies whether or not to try
- // harder by matching the query thumbnail URL as URL prefix. This affects
- // GetSource().
- const bool prefix_match_;
+ // Indicate that, when a URL for which we don't have a thumbnail is requested
+ // from this source, then Chrome should capture a thumbnail next time it
+ // navigates to this URL. This is useful when the thumbnail URLs are generated
+ // by an external service rather than TopSites, so Chrome can learn about the
+ // URLs for which it should get thumbnails. Sources that capture thumbnails
+ // are also be more lenient when matching thumbnail URLs by checking for
+ // existing thumbnails in the database that contain a URL matching the prefix
+ // of the requested URL.
+ const bool capture_thumbnails_;
DISALLOW_COPY_AND_ASSIGN(ThumbnailSource);
};
« no previous file with comments | « chrome/browser/ui/webui/ntp/thumbnail_list_source.cc ('k') | chrome/browser/ui/webui/ntp/thumbnail_source.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698