Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Issue 59903005: Fix for thin filled and hairline roundrects. (Closed)

Created:
7 years, 1 month ago by jvanverth1
Modified:
7 years, 1 month ago
Reviewers:
robertphillips
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

Fix for thin filled and hairline roundrects. The roundrect renderer was dropping into the ConvexPathRenderer when it didn't need to -- if a stroke is just on the edge of being acceptable it will now use the roundrect renderer. BUG=Skia:1802 Committed: http://code.google.com/p/skia/source/detail?r=12168

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M src/gpu/GrOvalRenderer.cpp View 4 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
jvanverth1
7 years, 1 month ago (2013-11-06 16:12:02 UTC) #1
robertphillips
lgtm short term but don't we still have a problem with the convex path renderer?
7 years, 1 month ago (2013-11-06 16:13:25 UTC) #2
jvanverth1
On 2013/11/06 16:13:25, robertphillips wrote: > lgtm short term but don't we still have a ...
7 years, 1 month ago (2013-11-06 16:23:34 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/jvanverth@google.com/59903005/1
7 years, 1 month ago (2013-11-06 16:34:43 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/jvanverth@google.com/59903005/1
7 years, 1 month ago (2013-11-07 16:34:40 UTC) #5
commit-bot: I haz the power
7 years, 1 month ago (2013-11-07 16:34:56 UTC) #6
Message was sent while issue was closed.
Change committed as 12168

Powered by Google App Engine
This is Rietveld 408576698