Issue 59903003: Remove TreatNullAs=NullString for HTMLButtonElement

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 59903003: Remove TreatNullAs=NullString for HTMLButtonElement (Closed)

Created:
7 years, 1 month ago by philipj_slow

Modified:
7 years, 1 month ago

Reviewers:
jochen (gone - plz use gerrit)

CC:
blink-reviews, dglazkov+blink, arv+blink, Inactive, adamk+blink_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/blink.git@nullb

Visibility:
Public.

More Reviews

Description

Remove TreatNullAs=NullString for HTMLButtonElement http://whatwg.org/html#htmlbuttonelement The tests for the updated properties pass in Firefox Nightly, IE11 Release Preview and Opera 12.16, with these exceptions: IE11 returns an empty string for HTMLButtonElement.type. Leave setCustomValidity until later, since it appears on several interfaces. BUG=310298 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=161455

Patch Set 1 #

Patch Set 2 : update tests #

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+46 lines, -31 lines)			Patch
M	LayoutTests/fast/dom/HTMLButtonElement/change-type.html	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	LayoutTests/fast/dom/HTMLButtonElement/change-type-expected.txt	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	LayoutTests/fast/dom/domstring-attribute-reflection.html	View	1	3 chunks	+9 lines, -4 lines	0 comments	Download
M	LayoutTests/fast/dom/domstring-attribute-reflection-expected.txt	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download
M	LayoutTests/fast/dom/element-attribute-js-null.html	View		1 chunk	+7 lines, -2 lines	0 comments	Download
M	LayoutTests/fast/dom/element-attribute-js-null-expected.txt	View		1 chunk	+7 lines, -2 lines	0 comments	Download
M	LayoutTests/fast/forms/submit-form-attributes.html	View	1	1 chunk	+6 lines, -6 lines	0 comments	Download
M	LayoutTests/fast/forms/submit-form-attributes-expected.txt	View	1	1 chunk	+6 lines, -6 lines	0 comments	Download
M	Source/core/html/HTMLButtonElement.idl	View		1 chunk	+7 lines, -7 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/philipj@opera.com/59903003/40001

7 years, 1 month ago (2013-11-06 13:16:43 UTC) #3

Message was sent while issue was closed.

Change committed as 161455

Expand Messages | Collapse Messages