Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(271)

Unified Diff: sdk/lib/async/future_impl.dart

Issue 598993002: Add missing null-tests to async error functions. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Add co19 issue number to status file. Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sdk/lib/async/future.dart ('k') | sdk/lib/async/stream.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sdk/lib/async/future_impl.dart
diff --git a/sdk/lib/async/future_impl.dart b/sdk/lib/async/future_impl.dart
index 124b7ab86069554514b84491e5fb8ae53a9bb80e..f3cd5e41c6b9b8ee4e6e69f0d14e1753b6652519 100644
--- a/sdk/lib/async/future_impl.dart
+++ b/sdk/lib/async/future_impl.dart
@@ -17,11 +17,11 @@ abstract class _Completer<T> implements Completer<T> {
void complete([value]);
void completeError(Object error, [StackTrace stackTrace]) {
- if (error == null) throw new ArgumentError("Error must not be null");
+ error = _nonNullError(error);
if (!future._mayComplete) throw new StateError("Future already completed");
AsyncError replacement = Zone.current.errorCallback(error, stackTrace);
if (replacement != null) {
- error = replacement.error;
+ error = _nonNullError(replacement.error);
stackTrace = replacement.stackTrace;
}
_completeError(error, stackTrace);
@@ -47,7 +47,6 @@ class _AsyncCompleter<T> extends _Completer<T> {
}
class _SyncCompleter<T> extends _Completer<T> {
-
void complete([value]) {
if (!future._mayComplete) throw new StateError("Future already completed");
future._complete(value);
« no previous file with comments | « sdk/lib/async/future.dart ('k') | sdk/lib/async/stream.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698