Add missing null-tests to async error functions.

sdk/lib/async/zone.dart

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 part of dart.async;
 
 typedef dynamic ZoneCallback();
 typedef dynamic ZoneUnaryCallback(arg);
 typedef dynamic ZoneBinaryCallback(arg1, arg2);
 
@@ skipping 18 matching lines @@
     Zone self, ZoneDelegate parent, Zone zone, Duration duration, void f());
 typedef Timer CreatePeriodicTimerHandler(
     Zone self, ZoneDelegate parent, Zone zone,
     Duration period, void f(Timer timer));
 typedef void PrintHandler(
     Zone self, ZoneDelegate parent, Zone zone, String line);
 typedef Zone ForkHandler(Zone self, ZoneDelegate parent, Zone zone,
                          ZoneSpecification specification,
                          Map zoneValues);
 
-/// Pair of error and stack trace. Returned by [Zone.errorCallback].
+/** Pair of error and stack trace. Returned by [Zone.errorCallback]. */
 class AsyncError implements Error {
   final error;
   final StackTrace stackTrace;
 
-  AsyncError(this.error, this.stackTrace);
+  AsyncError(this.error, this.stackTrace) {
+    if (error == null) throw new ArgumentError("Error must not be null");

[floitsch, 2014/09/24 12:59:14]

Or make it a NullThrownError?

+  }
+
   String toString() => error.toString();
 }
 
 
 class _ZoneFunction {
   final _Zone zone;
   final Function function;
   const _ZoneFunction(this.zone, this.function);
 }
 
@@ skipping 192 matching lines @@
 /**
  * A Zone represents the asynchronous version of a dynamic extent. Asynchronous
  * callbacks are executed in the zone they have been queued in. For example,
  * the callback of a `future.then` is executed in the same zone as the one where
  * the `then` was invoked.
  */
 abstract class Zone {
   // Private constructor so that it is not possible instantiate a Zone class.
   Zone._();
 
-  /// The root zone that is implicitly created.
+  /** The root zone that is implicitly created. */

[floitsch, 2014/09/24 12:59:14]

why this change?

[Lasse Reichstein Nielsen, 2014/09/24 13:49:57]

Just because the comment style was inconsistent with the rest of the file.

   static const Zone ROOT = _ROOT_ZONE;
 
-  /// The currently running zone.
+  /** The currently running zone. */
   static Zone _current = _ROOT_ZONE;
 
   static Zone get current => _current;
 
   dynamic handleUncaughtError(error, StackTrace stackTrace);
 
   /**
    * Returns the parent zone.
    *
    * Returns `null` if `this` is the [ROOT] zone.
@@ skipping 138 matching lines @@
    * or [Future] constructors that take an error or a callback that may throw,
    * the current zone is allowed to intercept and replace the error.
    *
    * When other libraries use intermediate controllers or completers, such
    * calls may contain errors that have already been processed.
    *
    * Return `null` if no replacement is desired.
    * The original error is used unchanged in that case.
    * Otherwise return an instance of [AsyncError] holding
    * the new pair of error and stack trace.
+   *
+   * The returned [AsyncError.error] must not be `null`.
    */
   AsyncError errorCallback(Object error, StackTrace stackTrace);
 
   /**
    * Runs [f] asynchronously in this zone.
    */
   void scheduleMicrotask(void f());
 
   /**
    * Creates a Timer where the callback is executed in this zone.
@@ skipping 811 matching lines @@
                                    handleUncaughtError: errorHandler);
   }
   Zone zone = Zone.current.fork(specification: zoneSpecification,
                                 zoneValues: zoneValues);
   if (onError != null) {
     return zone.runGuarded(body);
   } else {
     return zone.run(body);
   }
 }