Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(378)

Issue 598983004: Revert of Instrumented libraries: update the libnspr4 build script. (Closed)

Created:
6 years, 3 months ago by Lei Zhang
Modified:
6 years, 3 months ago
CC:
chromium-reviews, pbos
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Revert of Instrumented libraries: update the libnspr4 build script. (patchset #1 id:1 of https://codereview.chromium.org/600793002/) Reason for revert: MSAN bots failed. FAILED: cd ../../third_party/instrumented_libraries; ../../third_party/instrumented_libraries/download_build_install.py "--product-directory=../../out/Release" "--package=libnspr4" "--intermediate-directory=../../out/Release/obj/third_party/instrumented_libraries/msan-libnspr4.gen" "--sanitizer-type=msan" "--extra-configure-flags=--enable-64bit --disable-debug" "--cflags=-O2 -gline-tables-only -fPIC -w -U_FORITFY_SOURCE \"-fsanitize=memory\" \"-fsanitize-memory-track-origins=0\"" "--ldflags=-Wl,-z,origin -Wl,-R,XORIGIN/. \"-fsanitize=memory\"" "--cc=/mnt/data/b/build/goma/gomacc /mnt/data/b/build/slave/Chromium_Linux_MSan_Builder/build/src/third_party/llvm-build/Release+Asserts/bin/clang" "--cxx=/mnt/data/b/build/goma/gomacc /mnt/data/b/build/slave/Chromium_Linux_MSan_Builder/build/src/third_party/llvm-build/Release+Asserts/bin/clang++" "--jobs=10" "--build-method=destdir" "--run-before-build=scripts/libnspr4.sh" mv: cannot stat `nspr/*': No such file or directory Original issue's description: > Instrumented libraries: update the libnspr4 build script. > > There has been a security update in Precise which changed the paths somewhat. > > BUG=313751 > TBR=glider@chromium.org > NOTRY=true > > Committed: https://crrev.com/91e9dd404b29bcbb847b98530e83f3c40720b890 > Cr-Commit-Position: refs/heads/master@{#296395} TBR=glider@chromium.org,earthdok@chromium.org NOTREECHECKS=true NOTRY=true BUG=313751 Committed: https://crrev.com/5830d6a382f4f7b6bf64629c00d5ed4a2a9c0f4b Cr-Commit-Position: refs/heads/master@{#296454}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M third_party/instrumented_libraries/scripts/libnspr4.sh View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
Lei Zhang
Created Revert of Instrumented libraries: update the libnspr4 build script.
6 years, 3 months ago (2014-09-24 17:47:42 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/598983004/1
6 years, 3 months ago (2014-09-24 17:48:24 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1) as d6e5a6c6e56ce0ea2b09e0a7452bad83c093299e
6 years, 3 months ago (2014-09-24 17:49:13 UTC) #3
commit-bot: I haz the power
6 years, 3 months ago (2014-09-24 17:49:50 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5830d6a382f4f7b6bf64629c00d5ed4a2a9c0f4b
Cr-Commit-Position: refs/heads/master@{#296454}

Powered by Google App Engine
This is Rietveld 408576698