Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Issue 598953002: Make the detailed reason for deopts mandatory on all platforms. (Closed)

Created:
6 years, 3 months ago by Sven Panne
Modified:
6 years, 3 months ago
Reviewers:
Jarin
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Make the detailed reason for deopts mandatory on all platforms. Boring semi-mechanical stuff... R=jarin@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=24178

Patch Set 1 #

Patch Set 2 : rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+445 lines, -419 lines) Patch
M src/arm/lithium-codegen-arm.h View 1 chunk +1 line, -1 line 0 comments Download
M src/arm/lithium-codegen-arm.cc View 73 chunks +92 lines, -91 lines 0 comments Download
M src/arm64/lithium-codegen-arm64.h View 1 1 chunk +13 lines, -18 lines 0 comments Download
M src/arm64/lithium-codegen-arm64.cc View 1 69 chunks +98 lines, -94 lines 0 comments Download
M src/mips/lithium-codegen-mips.h View 1 chunk +4 lines, -6 lines 0 comments Download
M src/mips/lithium-codegen-mips.cc View 68 chunks +113 lines, -98 lines 0 comments Download
M src/mips64/lithium-codegen-mips64.h View 1 chunk +4 lines, -6 lines 0 comments Download
M src/mips64/lithium-codegen-mips64.cc View 71 chunks +120 lines, -105 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Sven Panne
6 years, 3 months ago (2014-09-24 09:59:44 UTC) #2
Jarin
lgtm
6 years, 3 months ago (2014-09-24 10:31:21 UTC) #3
Sven Panne
6 years, 3 months ago (2014-09-24 10:47:43 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as 24178 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698