Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(146)

Issue 598933004: Swap iteration order in TileGrid::insert(). (Closed)

Created:
6 years, 3 months ago by mtklein_C
Modified:
6 years, 3 months ago
Reviewers:
mtklein, robertphillips
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Swap iteration order in TileGrid::insert(). Was looking at performance here (it's the record hotspot) and noticed we iterate through the grid out of order. This is a tiny little thing, but it's probably orthogonal to any other performance improvements we'll make in here. BUG=skia: Committed: https://skia.googlesource.com/skia/+/eee606c7bf6b343429dcdbf56b6b71bd83575060

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M src/core/SkTileGrid.cpp View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
mtklein
6 years, 3 months ago (2014-09-24 14:25:13 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/598933004/1
6 years, 3 months ago (2014-09-24 14:25:35 UTC) #4
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
6 years, 3 months ago (2014-09-24 14:25:36 UTC) #5
robertphillips
lgtm
6 years, 3 months ago (2014-09-24 14:35:50 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/598933004/1
6 years, 3 months ago (2014-09-24 15:55:36 UTC) #9
commit-bot: I haz the power
6 years, 3 months ago (2014-09-24 15:59:42 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as eee606c7bf6b343429dcdbf56b6b71bd83575060

Powered by Google App Engine
This is Rietveld 408576698