cc/blink/web_filter_animation_curve_impl.h - Issue 598853003: CC: Add curve (whole animation) timing function to compositor animations.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: cc/blink/web_filter_animation_curve_impl.h

Issue 598853003: CC: Add curve (whole animation) timing function to compositor animations. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Renamed functions. Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« cc/animation/keyframed_animation_curve.cc ('K') | « cc/animation/keyframed_animation_curve_unittest.cc ('k') | cc/blink/web_filter_animation_curve_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: cc/blink/web_filter_animation_curve_impl.h

diff --git a/cc/blink/web_filter_animation_curve_impl.h b/cc/blink/web_filter_animation_curve_impl.h

index 0454cce549eef1092326f4c700e63556f62a894b..d6be0aae65363e882762ff4ce771e4b4d268394b 100644

--- a/cc/blink/web_filter_animation_curve_impl.h

+++ b/cc/blink/web_filter_animation_curve_impl.h

@@ -36,6 +36,10 @@ class WebFilterAnimationCurveImpl : public blink::WebFilterAnimationCurve {

double y1,

double x2,

double y2);

+#if WEB_ANIMATION_SUPPORTS_ANIMATION_TIMING

ajuma 2014/09/25 14:44:38 Since you're just adding new methods rather than c

ikilpatrick 2014/09/25 22:54:58 Done.

+ virtual void setTimingFunction(TimingFunctionType = TimingFunctionTypeEase);

ajuma 2014/09/25 14:44:38 No default argument; the one on the Blink side is

ikilpatrick 2014/09/25 22:54:58 Done.

+ virtual void setTimingFunction(double x1, double y1, double x2, double y2);

+#endif

scoped_ptr<cc::AnimationCurve> CloneToAnimationCurve() const;

« cc/animation/keyframed_animation_curve.cc ('K') | « cc/animation/keyframed_animation_curve_unittest.cc ('k') | cc/blink/web_filter_animation_curve_impl.cc » ('j') | no next file with comments »