Issue 59883019: Fix json message in debugger wire protocol

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 59883019: Fix json message in debugger wire protocol (Closed)

Created:
7 years, 1 month ago by hausner

Modified:
7 years, 1 month ago

Reviewers:
devoncarew

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

Fix json message in debugger wire protocol Removed faulty comma in message. This hopefully solves issue 13792. R=devoncarew@google.com Committed: https://code.google.com/p/dart/source/detail?r=30311

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+12 lines, -3 lines)			Patch
	M	runtime/bin/dbg_message.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	runtime/platform/json.cc	View		1 chunk	+11 lines, -2 lines	0 comments	Download

Total messages: 3 (0 generated)

hausner

Devon, this fixes issue 13792 for me, at least the assertion goes away when I ...

7 years, 1 month ago (2013-11-15 18:26:24 UTC) #1

hausner

7 years, 1 month ago (2013-11-15 19:14:52 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r30311 (presubmit successful).