Issue 59883011: Revert "StyleResolverParentPusher can decide if it needs to push at creation time"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 59883011: Revert "StyleResolverParentPusher can decide if it needs to push at creation time" (Closed)

Created:
7 years, 1 month ago by esprehn

Modified:
7 years, 1 month ago

Reviewers:
leviw_travelin_and_unemployed, bulach, ojan

CC:
blink-reviews, dglazkov+blink, eae+blinkwatch, adamk+blink_chromium.org

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

Revert "StyleResolverParentPusher can decide if it needs to push at creation time" This commit reverts http://src.chromium.org/viewvc/blink?view=revision&revision=161770 Previously we'd never push the bloom filter for Elements that contained only Text nodes, but r161770 made us start doing that. Apparently the bloom filter updating is expensive: 8-10% more than just regular text style updating since text doesn't need to selector match and the bloom filter is just wasted work. BUG=318660 TBR=leviw@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=161943

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+31 lines, -13 lines)			Patch
	M	Source/core/dom/Element.cpp	View		5 chunks	+31 lines, -13 lines	0 comments	Download

Total messages: 2 (0 generated)

esprehn

7 years, 1 month ago (2013-11-13 20:20:41 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 manually as r161943 (presubmit successful).