chrome/browser/sync/profile_sync_service.cc - Issue 59883010: This is the fourth CL of several that will eventually replace TokenService with

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/sync/profile_sync_service.cc

Issue 59883010: This is the fourth CL of several that will eventually replace TokenService with (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Fix condition in ProfileSyncService::TryStart() Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/sync/profile_sync_service.cc

diff --git a/chrome/browser/sync/profile_sync_service.cc b/chrome/browser/sync/profile_sync_service.cc

index 990b1ad255ab0e182093b6a290da5c2961b2085c..710fb757315f96d0b9ed9466ba5c5bc6e3c52388 100644

--- a/chrome/browser/sync/profile_sync_service.cc

+++ b/chrome/browser/sync/profile_sync_service.cc

@@ -279,13 +279,11 @@ void ProfileSyncService::TryStart() {

if (!IsSyncEnabledAndLoggedIn())

return;

- // On auto_start platforms (like ChromeOS) we don't start sync until tokens

- // are loaded, because the user can be "signed in" on those platforms long

- // before the tokens get loaded, and we don't want to generate spurious

- // auth errors.

- if (!IsOAuthRefreshTokenAvailable() && !(!auto_start_enabled_)) {

+ // Don't start sync until tokens are loaded, because the user can be

+ // "signed in" long before the tokens get loaded, and we don't want to

+ // generate spurious auth errors.

+ if (!IsOAuthRefreshTokenAvailable())

Roger Tawa OOO till Jul 10th 2013/11/13 20:23:10 I modified this condition as we discussed over ema

return;

- }

// If we got here then tokens are loaded and user logged in and sync is

// enabled. If OAuth refresh token is not available then something is wrong.

« no previous file with comments | « chrome/browser/managed_mode/managed_user_service_factory.cc ('k') | no next file » | no next file with comments »