This is the fourth CL of several that will eventually replace TokenService with

This is the fourth CL of several that will eventually replace TokenService with
ProfileOAuth2TokenService. In this CL, the dependencies on TS are removed
from chromeos code and managed user code.

BUG=305247
TBR=rlp@chromium.org,davemoore@chromium.org,asvitkine@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=236865

[Roger Tawa OOO till Jul 10th, 2013-11-13 20:23:10]

Hi Pavel, Tim,

Please take a look.  Thanks.

https://codereview.chromium.org/59883010/diff/40001/chrome/browser/sync/profi...
File chrome/browser/sync/profile_sync_service.cc (right):

https://codereview.chromium.org/59883010/diff/40001/chrome/browser/sync/profi...
chrome/browser/sync/profile_sync_service.cc:285: if
(!IsOAuthRefreshTokenAvailable())
I modified this condition as we discussed over email.

[Roger Tawa OOO till Jul 10th, 2013-11-13 20:24:08]

On 2013/11/13 20:23:10, Roger Tawa wrote:
> Hi Pavel, Tim,
> 
> Please take a look.  Thanks.
> 
>
https://codereview.chromium.org/59883010/diff/40001/chrome/browser/sync/profi...
> File chrome/browser/sync/profile_sync_service.cc (right):
> 
>
https://codereview.chromium.org/59883010/diff/40001/chrome/browser/sync/profi...
> chrome/browser/sync/profile_sync_service.cc:285: if
> (!IsOAuthRefreshTokenAvailable())
> I modified this condition as we discussed over email.

Oops, please disregard.  I uploaded this change to the wrong CL.

[Roger Tawa OOO till Jul 10th, 2013-11-13 21:44:31]

Hi Bernhard, Xiyuan,

Bernard: please review managed_user_service_factory.cc

Xiyuan: please review the chromeos files.

Thanks.

[Bernhard Bauer, 2013-11-14 16:42:13]

managed_mode/ LGTM.

https://codereview.chromium.org/59883010/diff/140001/chrome/browser/managed_m...
File chrome/browser/managed_mode/managed_user_service_factory.cc (right):

https://codereview.chromium.org/59883010/diff/140001/chrome/browser/managed_m...
chrome/browser/managed_mode/managed_user_service_factory.cc:36:
DependsOn(ProfileOAuth2TokenServiceFactory::GetInstance());
Note that ManagedUserService does not depend on PO2TS at construction or
destruction time, so I don't think this is strictly necessary. It's fine with me
if it works now, but the last time I tried this, it caused some weird error at
construction time, because some service was created too early.

[xiyuan, 2013-11-14 17:51:11]

c/b/chromeos/* LGTM

[Roger Tawa OOO till Jul 10th, 2013-11-14 18:19:41]

Thanks Bernhard, Xiyuan.

https://codereview.chromium.org/59883010/diff/140001/chrome/browser/managed_m...
File chrome/browser/managed_mode/managed_user_service_factory.cc (right):

https://codereview.chromium.org/59883010/diff/140001/chrome/browser/managed_m...
chrome/browser/managed_mode/managed_user_service_factory.cc:36:
DependsOn(ProfileOAuth2TokenServiceFactory::GetInstance());
On 2013/11/14 16:42:14, Bernhard Bauer wrote:
> Note that ManagedUserService does not depend on PO2TS at construction or
> destruction time, so I don't think this is strictly necessary. It's fine with
me
> if it works now, but the last time I tried this, it caused some weird error at
> construction time, because some service was created too early.

Got it.  I think the error was likely due to PO2TS depending on TokenSercvice,
which itself depended on other services.  I'll double check that this causes no
problems.

[commit-bot: I haz the power, 2013-11-17 01:20:36]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rogerta@chromium.org/59883010/710001

[commit-bot: I haz the power, 2013-11-17 02:37:57]

Retried try job too often on linux_chromeos for step(s) unit_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chro...

[Roger Tawa OOO till Jul 10th, 2013-11-17 05:38:44]

Hi Pawel,

Please review changes in in chrome\test.  Thanks.

[Paweł Hajdan Jr., 2013-11-18 19:59:32]

https://codereview.chromium.org/59883010/diff/1000001/chrome/test/base/testin...
File chrome/test/base/testing_profile_manager.h (right):

https://codereview.chromium.org/59883010/diff/1000001/chrome/test/base/testin...
chrome/test/base/testing_profile_manager.h:61: TestingProfile*
CreateTestingProfile(const std::string& profile_name,
Can we delete this and convert callers if there aren't too many?

Having a method with 1 arg vs. 6 args makes sense, but 6 vs. 5 vs. 1 much less.

[Roger Tawa OOO till Jul 10th, 2013-11-18 20:03:23]

On 2013/11/18 19:59:32, Paweł Hajdan Jr. wrote:
>
https://codereview.chromium.org/59883010/diff/1000001/chrome/test/base/testin...
> File chrome/test/base/testing_profile_manager.h (right):
> 
>
https://codereview.chromium.org/59883010/diff/1000001/chrome/test/base/testin...
> chrome/test/base/testing_profile_manager.h:61: TestingProfile*
> CreateTestingProfile(const std::string& profile_name,
> Can we delete this and convert callers if there aren't too many?
> 
> Having a method with 1 arg vs. 6 args makes sense, but 6 vs. 5 vs. 1 much
less.

Sure, but there are many callers so that should be done as a separate CL.  I can
open a bug to track it if you like.

[Paweł Hajdan Jr., 2013-11-19 00:11:39]

On 2013/11/18 20:03:23, Roger Tawa wrote:
> Sure, but there are many callers so that should be done as a separate CL.  I
can
> open a bug to track it if you like.

Using cs.chromium.org I only see ~7 files that'd be affected by this. I think
it's better to do the conversion now. It's important to keep chrome/test APIs
very clean.

[Roger Tawa OOO till Jul 10th, 2013-11-21 04:10:26]

Pawel: PTAL.

[Paweł Hajdan Jr., 2013-11-22 16:45:54]

LGTM, thank you.

[commit-bot: I haz the power, 2013-11-22 18:20:49]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rogerta@chromium.org/59883010/1460001

[commit-bot: I haz the power, 2013-11-22 18:41:51]

Retried try job too often on chromium_presubmit for step(s) presubmit
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_p...

[Alexei Svitkine (slow), 2013-11-22 19:13:04]

cocoa/ lgtm

[commit-bot: I haz the power, 2013-11-22 21:44:37]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rogerta@chromium.org/59883010/1630001

[commit-bot: I haz the power, 2013-11-22 23:21:28]

Change committed as 236865