Issue 598743002: [Password Generation] Update strings

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 598743002: [Password Generation] Update strings (Closed)

Created:
6 years, 3 months ago by Garrett Casto

Modified:
6 years, 3 months ago

Reviewers:
vabr (Chromium)

CC:
chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Project:
chromium

Visibility:
Public.

[Password Generation] Update strings BUG=318977 Committed: https://crrev.com/fac46ddd1c2c392830f7a48f9def1c196d9f7bb1 Cr-Commit-Position: refs/heads/master@{#296487}

Created: 6 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+3 lines, -3 lines)			Patch
M	chrome/app/chromium_strings.grd	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/app/generated_resources.grd	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/app/google_chrome_strings.grd	View	1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 7 (2 generated)

vabr (Chromium)

LGTM, based on http://crbug.com/318977#c65. Cheers, Vaclav

6 years, 3 months ago (2014-09-24 08:43:33 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/598743002/1

6 years, 3 months ago (2014-09-24 18:23:23 UTC) #5

commit-bot: I haz the power

Committed patchset #1 (id:1) as 9c7d186c1c89e1f46553635e9bcf6ffb3d75ed7d

6 years, 3 months ago (2014-09-24 19:28:44 UTC) #6

commit-bot: I haz the power

6 years, 3 months ago (2014-09-24 19:29:29 UTC) #7

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/fac46ddd1c2c392830f7a48f9def1c196d9f7bb1
Cr-Commit-Position: refs/heads/master@{#296487}