Issue 59873006: NativeAppWindowGtk: only notify change when the window state actually changes

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 59873006: NativeAppWindowGtk: only notify change when the window state actually changes (Closed)

Created:
7 years, 1 month ago by mlamouri (slow - plz ping)

Modified:
7 years, 1 month ago

Reviewers:
benwells

CC:
chromium-reviews, tfarina, chrome-apps-reviews_chromium.org, chrome-apps-syd-reviews_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

NativeAppWindowGtk: only notify change when the window state actually changes. In ::OnXEvent(), we notify of a change in the window, even if the |state_| of the window stays the same. Checking that there was actually a state change would prevent some wasted calls. BUG=None Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=233523

Patch Set 1 #

Patch Set 2 : #

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -3 lines)			Patch
	M	chrome/browser/ui/gtk/apps/native_app_window_gtk.cc	View	1	1 chunk	+4 lines, -3 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mlamouri@chromium.org/59873006/30001

7 years, 1 month ago (2013-11-06 22:24:50 UTC) #3

commit-bot: I haz the power

Step "update" is always a major failure. Look at the try server FAQ for more ...

7 years, 1 month ago (2013-11-06 23:07:25 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mlamouri@chromium.org/59873006/30001

7 years, 1 month ago (2013-11-07 01:42:36 UTC) #5

Message was sent while issue was closed.

Change committed as 233523

Expand Messages | Collapse Messages