Center the font height instead of cap height when cap height is not supported.

Center the font height instead of cap height when cap height is not supported.

This CL centers the font height when cap height is not supported (actually it's CrOS and Linux).  This behavior is the same before http://crrev.com/54353002 .

BUG=314688
TEST=Test manually.

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=233529

[Yuki, 2013-11-05 14:04:21]

Could you review this CL?

http://crrev.com/54353002 has the ascent centered when cap height is not
supported.  However, it turned out that we should have the font height centered
when cap height is not supported, as the same before.

[Peter Kasting, 2013-11-05 22:18:01]

LGTM

Is there some bug tracking implementing a real GetCapHeight() for CrOS/GTK?  Are
you planning on doing this?  It would be nice to fix this "correctly".

https://codereview.chromium.org/59873002/diff/1/chrome/browser/ui/views/locat...
File chrome/browser/ui/views/location_bar/location_bar_view.cc (right):

https://codereview.chromium.org/59873002/diff/1/chrome/browser/ui/views/locat...
chrome/browser/ui/views/location_bar/location_bar_view.cc:150: // height
centered.  If not, we have the font height centered.
Nit: How about this:

Some platforms don't support getting the cap height, and simply return the
entire font ascent from GetCapHeight().  Centering the ascent makes the font
look too low, so if GetCapHeight() returns the ascent, center the entire font
height instead.

[Yuki, 2013-11-06 02:38:42]

Filed an issue: https://code.google.com/p/chromium/issues/detail?id=315402

Thanks.

https://codereview.chromium.org/59873002/diff/1/chrome/browser/ui/views/locat...
File chrome/browser/ui/views/location_bar/location_bar_view.cc (right):

https://codereview.chromium.org/59873002/diff/1/chrome/browser/ui/views/locat...
chrome/browser/ui/views/location_bar/location_bar_view.cc:150: // height
centered.  If not, we have the font height centered.
On 2013/11/05 22:18:01, Peter Kasting wrote:
> Nit: How about this:
> 
> Some platforms don't support getting the cap height, and simply return the
> entire font ascent from GetCapHeight().  Centering the ascent makes the font
> look too low, so if GetCapHeight() returns the ascent, center the entire font
> height instead.

Done.

[commit-bot: I haz the power, 2013-11-06 02:50:15]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/yukishiino@chromium.org/59873002/100001

[commit-bot: I haz the power, 2013-11-06 04:44:57]

Retried try job too often on linux_chromeos for step(s) browser_tests,
check_deps, content_browsertests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chro...

[commit-bot: I haz the power, 2013-11-06 05:24:09]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/yukishiino@chromium.org/59873002/100001

[commit-bot: I haz the power, 2013-11-06 09:07:21]

Retried try job too often on linux_aura for step(s) browser_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_aura...

[commit-bot: I haz the power, 2013-11-06 09:20:52]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/yukishiino@chromium.org/59873002/100001

[commit-bot: I haz the power, 2013-11-06 12:31:42]

Retried try job too often on linux_aura for step(s) browser_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_aura...

[commit-bot: I haz the power, 2013-11-06 12:36:24]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/yukishiino@chromium.org/59873002/460001

[commit-bot: I haz the power, 2013-11-06 15:21:19]

Step "update" is always a major failure.
Look at the try server FAQ for more details.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win7_aura&...

[commit-bot: I haz the power, 2013-11-07 02:46:26]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/yukishiino@chromium.org/59873002/460001

[commit-bot: I haz the power, 2013-11-07 05:36:06]

Retried try job too often on win_rel for step(s) browser_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

[commit-bot: I haz the power, 2013-11-07 06:18:50]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/yukishiino@chromium.org/59873002/460001

[commit-bot: I haz the power, 2013-11-07 07:39:49]

Change committed as 233529