Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(138)

Issue 598723002: Enable FDO for v8 in android build. (Closed)

Created:
6 years, 3 months ago by dehao
Modified:
6 years, 2 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8@master
Project:
v8
Visibility:
Public.

Description

Enable FDO for v8 in android build. R=benm@chromium.org, ulan@chromium.org, torne@chromium.org TEST=manual BUG= Committed: https://code.google.com/p/v8/source/detail?r=24219

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -0 lines) Patch
M build/toolchain.gypi View 2 chunks +12 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
dehao
6 years, 3 months ago (2014-09-23 21:18:53 UTC) #1
benm (inactive)
lgtm
6 years, 3 months ago (2014-09-24 08:58:44 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/598723002/1
6 years, 3 months ago (2014-09-24 16:16:33 UTC) #5
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years, 3 months ago (2014-09-24 16:16:34 UTC) #7
benm (inactive)
Jakob, Ulan, could you take a look please? Thanks
6 years, 3 months ago (2014-09-24 16:22:12 UTC) #9
ulan
On 2014/09/24 16:22:12, benm wrote: > Jakob, Ulan, could you take a look please? > ...
6 years, 2 months ago (2014-09-25 09:24:49 UTC) #10
ulan
Committed patchset #1 (id:1) manually as 24219 (tree was closed).
6 years, 2 months ago (2014-09-25 10:19:16 UTC) #11
Torne
6 years, 2 months ago (2014-10-09 15:32:47 UTC) #12
Message was sent while issue was closed.
On 2014/09/25 10:19:16, ulan wrote:
> Committed patchset #1 (id:1) manually as 24219 (tree was closed).

Hi Ulan,

This didn't get rolled into Chrome in time for the M39 branch point; would it be
possible to cherrypick it to the V8 release branch for M39? What's the process
for that?

Powered by Google App Engine
This is Rietveld 408576698