Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Issue 598703003: convert disassembler to use OStream (Closed)

Created:
6 years, 3 months ago by dcarney
Modified:
6 years, 2 months ago
Reviewers:
Sven Panne
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

convert disassembler to use OStream R=svenpanne@chromium.org BUG= Committed: https://code.google.com/p/v8/source/detail?r=24214

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -98 lines) Patch
M src/disassembler.h View 1 2 1 chunk +4 lines, -14 lines 0 comments Download
M src/disassembler.cc View 1 8 chunks +13 lines, -56 lines 0 comments Download
M src/ia32/assembler-ia32.h View 1 1 chunk +0 lines, -3 lines 0 comments Download
M src/ia32/assembler-ia32.cc View 1 1 chunk +0 lines, -5 lines 0 comments Download
M src/objects.cc View 1 2 1 chunk +12 lines, -3 lines 0 comments Download
M test/cctest/test-assembler-ia32.cc View 1 2 3 4 3 chunks +11 lines, -17 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
dcarney
ptal
6 years, 3 months ago (2014-09-24 12:50:47 UTC) #2
Sven Panne
lgtm
6 years, 3 months ago (2014-09-24 12:59:52 UTC) #3
dcarney
6 years, 2 months ago (2014-09-25 08:33:35 UTC) #4
Message was sent while issue was closed.
Committed patchset #5 (id:80001) manually as 24214 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698