Issue 598643003: Don't run windows tests on other platforms

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 598643003: Don't run windows tests on other platforms (Closed)

Created:
6 years, 3 months ago by scottmg

Modified:
6 years, 3 months ago

Reviewers:
Timur Iskhodzhanov

CC:
gyp-developer_googlegroups.com

Base URL:
http://gyp.googlecode.com/svn/trunk

Visibility:
Public.

More Reviews

Description

Don't run windows tests on other platforms Build fix TBR=timurrrr@chromium.org Committed: https://code.google.com/p/gyp/source/detail?r=1979

Patch Set 1 #

Created: 6 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+12 lines, -9 lines)			Patch
	M	pylib/gyp/generator/ninja_test.py	View		1 chunk	+12 lines, -9 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

scottmg

Committed patchset #1 (id:1) manually as 1979 (presubmit successful).

6 years, 3 months ago (2014-09-23 16:48:54 UTC) #1

Timur Iskhodzhanov

Are you sure you've meant to use me as a reviewer?

6 years, 3 months ago (2014-09-23 16:52:22 UTC) #2

scottmg

On 2014/09/23 16:52:22, Timur Iskhodzhanov wrote: > Are you sure you've meant to use me ...

6 years, 3 months ago (2014-09-23 16:58:37 UTC) #3

scottmg

6 years, 3 months ago (2014-09-23 18:41:13 UTC) #4

Message was sent while issue was closed.

On 2014/09/23 16:58:37, scottmg wrote:
> On 2014/09/23 16:52:22, Timur Iskhodzhanov wrote:
> > Are you sure you've meant to use me as a reviewer?
> 
> It was caused by the previous CL, so just a follow up to that. I'm not sure
why
> these tests were running on non-Windows before, doesn't really make any sense.

I reverted this and r1978, there's a few tests that need to be addressed that
rely on pretending to have a particular version installed even though it's not.

Expand Messages | Collapse Messages