Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(101)

Issue 59863004: Remove dead NavigationControllerImpl::IsRedirect. (Closed)

Created:
7 years, 1 month ago by Charlie Reis
Modified:
7 years, 1 month ago
Reviewers:
nasko
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, site-isolation-reviews_chromium.org
Visibility:
Public.

Description

Remove dead NavigationControllerImpl::IsRedirect. BUG=none TEST=No behavior change. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=233160

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -13 lines) Patch
M content/browser/frame_host/navigation_controller_impl.h View 1 chunk +0 lines, -3 lines 0 comments Download
M content/browser/frame_host/navigation_controller_impl.cc View 1 chunk +0 lines, -10 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Charlie Reis
Another quick one. Nasko, you might be relieved by having one fewer redirect concept to ...
7 years, 1 month ago (2013-11-05 18:34:49 UTC) #1
nasko
Definitely LGTM!!!
7 years, 1 month ago (2013-11-05 18:51:07 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/creis@chromium.org/59863004/1
7 years, 1 month ago (2013-11-05 19:00:26 UTC) #3
commit-bot: I haz the power
7 years, 1 month ago (2013-11-06 00:38:29 UTC) #4
Message was sent while issue was closed.
Change committed as 233160

Powered by Google App Engine
This is Rietveld 408576698