Source/core/frame/Window.idl - Issue 59863003: window.scroll() without params should be ignored or throw an error

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/frame/Window.idl

Issue 59863003: window.scroll() without params should be ignored or throw an error (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Rebase test & test results of non-numeric-values-numeric-parameters test. Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/frame/Window.idl

diff --git a/Source/core/frame/Window.idl b/Source/core/frame/Window.idl

index 86dd8e0bcb93afd4b418683936cc27567aad5200..10f5f23733d0a5d1827a9ffab3b9d9d4e7a6ae14 100644

--- a/Source/core/frame/Window.idl

+++ b/Source/core/frame/Window.idl

@@ -93,9 +93,9 @@

readonly attribute long pageXOffset;

readonly attribute long pageYOffset;

- void scrollBy([Default=Undefined] optional long x, [Default=Undefined] optional long y);

- void scrollTo([Default=Undefined] optional long x, [Default=Undefined] optional long y);

- void scroll([Default=Undefined] optional long x, [Default=Undefined] optional long y);

+ void scrollBy(long x, long y);

+ void scrollTo(long x, long y);

+ void scroll(long x, long y);

void moveBy([Default=Undefined] optional float x, [Default=Undefined] optional float y); // FIXME: this should take longs not floats.

void moveTo([Default=Undefined] optional float x, [Default=Undefined] optional float y); // FIXME: this should take longs not floats.

void resizeBy([Default=Undefined] optional float x, [Default=Undefined] optional float y); // FIXME: this should take longs not floats.

« no previous file with comments | « LayoutTests/fast/dom/script-tests/non-numeric-values-numeric-parameters.js ('k') | no next file » | no next file with comments »