Issue 59863002: DevTools Timeline: remove hard-coded pixel-sized adjustments from overview's CSS

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 59863002: DevTools Timeline: remove hard-coded pixel-sized adjustments from overview's CSS (Closed)

Created:
7 years, 1 month ago by caseq

Modified:
7 years, 1 month ago

Reviewers:
vsevik, pfeldman

CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, alph+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, aandrey+blink_chromium.org, pfeldman

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Replace hard-coded pixel sized adjustments of overview items in CSS with flex, so we can play with overview size. BUG=305863 R=pfeldman@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=161341

Patch Set 1 #

Total comments: 1

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+14 lines, -13 lines)			Patch
	M	Source/devtools/front_end/TimelineOverviewPane.js	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	Source/devtools/front_end/timelinePanel.css	View		3 chunks	+13 lines, -12 lines	1 comment	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

pfeldman

lgtm https://codereview.chromium.org/59863002/diff/1/Source/devtools/front_end/timelinePanel.css File Source/devtools/front_end/timelinePanel.css (right): https://codereview.chromium.org/59863002/diff/1/Source/devtools/front_end/timelinePanel.css#newcode31 Source/devtools/front_end/timelinePanel.css:31: flex: 0 0 91px; keep it 81

7 years, 1 month ago (2013-11-05 14:19:29 UTC) #2

caseq

7 years, 1 month ago (2013-11-05 15:11:48 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r161341 (presubmit successful).

Expand Messages | Collapse Messages