Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(375)

Issue 598603003: Use athena version of content::WebContentsViewDelegate when USE_ATHENA is defned (Closed)

Created:
6 years, 3 months ago by pkotwicz
Modified:
6 years, 3 months ago
Reviewers:
oshima, sky
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Use athena version of content::WebContentsViewDelegate when USE_ATHENA is defned BUG=414781, 416859 TEST=Manual, see bug Committed: https://crrev.com/295d0f471e76fdef581d50f2893f4ba28380bd76 Cr-Commit-Position: refs/heads/master@{#296336}

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M chrome/browser/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/chrome_content_browser_client.cc View 2 chunks +5 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
pkotwicz
Oshima PTAL
6 years, 3 months ago (2014-09-23 16:04:35 UTC) #3
oshima
lgtm
6 years, 3 months ago (2014-09-23 17:14:46 UTC) #4
pkotwicz
sky@ for OWNERS
6 years, 3 months ago (2014-09-23 17:58:37 UTC) #6
sky
LGTM
6 years, 3 months ago (2014-09-23 22:27:03 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/598603003/20001
6 years, 3 months ago (2014-09-24 02:07:11 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:20001) as c60e73aabe68f6bbcd2e646986d7acdd41062f76
6 years, 3 months ago (2014-09-24 03:15:20 UTC) #10
commit-bot: I haz the power
6 years, 3 months ago (2014-09-24 03:15:52 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/295d0f471e76fdef581d50f2893f4ba28380bd76
Cr-Commit-Position: refs/heads/master@{#296336}

Powered by Google App Engine
This is Rietveld 408576698