Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 598593006: Remove forward declarations from Source/core/dom/custom (Closed)

Created:
6 years, 2 months ago by deepak.sa
Modified:
6 years, 2 months ago
CC:
blink-reviews, webcomponents-bugzilla_chromium.org, sof, eae+blinkwatch, blink-reviews-dom_chromium.org, dglazkov+blink, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Remove forward declarations from Source/core/dom/custom This patch removes unneeded forward references and add closing comment for namespace blink Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=182892

Patch Set 1 #

Total comments: 6

Patch Set 2 : Nits #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -47 lines) Patch
M Source/core/dom/custom/CustomElement.h View 2 chunks +1 line, -2 lines 0 comments Download
M Source/core/dom/custom/CustomElementAsyncImportMicrotaskQueue.h View 2 chunks +2 lines, -3 lines 0 comments Download
M Source/core/dom/custom/CustomElementCallbackInvocation.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/custom/CustomElementCallbackQueue.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/custom/CustomElementDefinition.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/custom/CustomElementDefinition.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/custom/CustomElementException.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/custom/CustomElementLifecycleCallbacks.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/custom/CustomElementMicrotaskDispatcher.h View 2 chunks +1 line, -5 lines 0 comments Download
M Source/core/dom/custom/CustomElementMicrotaskImportStep.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/custom/CustomElementMicrotaskQueueBase.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/custom/CustomElementMicrotaskResolutionStep.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/custom/CustomElementMicrotaskRunQueue.h View 1 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/dom/custom/CustomElementMicrotaskStep.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/custom/CustomElementObserver.h View 2 chunks +1 line, -2 lines 0 comments Download
M Source/core/dom/custom/CustomElementProcessingStack.h View 2 chunks +1 line, -3 lines 0 comments Download
M Source/core/dom/custom/CustomElementProcessingStep.h View 2 chunks +1 line, -3 lines 0 comments Download
M Source/core/dom/custom/CustomElementRegistrationContext.h View 2 chunks +1 line, -6 lines 0 comments Download
M Source/core/dom/custom/CustomElementRegistry.h View 1 2 chunks +1 line, -2 lines 0 comments Download
M Source/core/dom/custom/CustomElementScheduler.h View 2 chunks +1 line, -3 lines 0 comments Download
M Source/core/dom/custom/CustomElementSyncMicrotaskQueue.h View 1 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/dom/custom/CustomElementUpgradeCandidateMap.h View 2 chunks +1 line, -3 lines 0 comments Download
M Source/core/dom/custom/CustomElementUpgradeCandidateMap.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
deepak.sa
PTAL? Thanks!
6 years, 2 months ago (2014-09-30 06:03:59 UTC) #2
sof
lgtm % nits https://codereview.chromium.org/598593006/diff/1/Source/core/dom/custom/CustomElementMicrotaskRunQueue.h File Source/core/dom/custom/CustomElementMicrotaskRunQueue.h (left): https://codereview.chromium.org/598593006/diff/1/Source/core/dom/custom/CustomElementMicrotaskRunQueue.h#oldcode49 Source/core/dom/custom/CustomElementMicrotaskRunQueue.h:49: #endif Add // CustomElementMicrotaskRunQueue_h https://codereview.chromium.org/598593006/diff/1/Source/core/dom/custom/CustomElementRegistry.h File ...
6 years, 2 months ago (2014-09-30 06:17:59 UTC) #4
deepak.sa
https://codereview.chromium.org/598593006/diff/1/Source/core/dom/custom/CustomElementMicrotaskRunQueue.h File Source/core/dom/custom/CustomElementMicrotaskRunQueue.h (left): https://codereview.chromium.org/598593006/diff/1/Source/core/dom/custom/CustomElementMicrotaskRunQueue.h#oldcode49 Source/core/dom/custom/CustomElementMicrotaskRunQueue.h:49: #endif On 2014/09/30 06:17:58, sof wrote: > Add // ...
6 years, 2 months ago (2014-09-30 06:35:14 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/598593006/20001
6 years, 2 months ago (2014-09-30 06:35:55 UTC) #7
commit-bot: I haz the power
6 years, 2 months ago (2014-09-30 07:44:59 UTC) #8
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as 182892

Powered by Google App Engine
This is Rietveld 408576698