Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Issue 598593003: Fix DecompressionTask with power-of-two expanded thumbnails. (Closed)

Created:
6 years, 3 months ago by aelias_OOO_until_Jul13
Modified:
6 years, 3 months ago
Reviewers:
Ted C, Yusuf, clholgat
CC:
chromium-reviews, David Trainor- moved to gerrit, klobag.chromium
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Fix DecompressionTask with power-of-two expanded thumbnails. Older versions of Chrome expanded thumbnails to 1024x1024 to work around an IMG driver bug. When these were processed through DecompressionTask, they got corrupted because this method assumed the content size and buffer size were the same. This patch changes it to decompress into a potentially larger buffer then copy if needed. BUG=416437 Committed: https://crrev.com/93778c0cb6edfe0d5b1146e2797fbac9abadaf14 Cr-Commit-Position: refs/heads/master@{#296341}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Fix indentation #

Patch Set 3 : Make decode failure mode not have pixels for consistency #

Patch Set 4 : Use Skia methods instead of recomputing pixel size and stride #

Patch Set 5 : Update comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -14 lines) Patch
M chrome/browser/android/thumbnail/thumbnail_store.cc View 1 2 3 4 1 chunk +35 lines, -14 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
aelias_OOO_until_Jul13
PTAL. tedchoc@ for OWNERS, yusufo@ and clholgat@ for initial review.
6 years, 3 months ago (2014-09-23 23:28:35 UTC) #2
Yusuf
lgtm with a styling nit https://codereview.chromium.org/598593003/diff/1/chrome/browser/android/thumbnail/thumbnail_store.cc File chrome/browser/android/thumbnail/thumbnail_store.cc (right): https://codereview.chromium.org/598593003/diff/1/chrome/browser/android/thumbnail/thumbnail_store.cc#newcode877 chrome/browser/android/thumbnail/thumbnail_store.cc:877: raw_data_small.allocPixels(SkImageInfo::Make(content_size.width(), indent +4
6 years, 3 months ago (2014-09-23 23:52:49 UTC) #3
Ted C
lgtm
6 years, 3 months ago (2014-09-24 02:40:43 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/598593003/80001
6 years, 3 months ago (2014-09-24 02:56:46 UTC) #6
commit-bot: I haz the power
Committed patchset #5 (id:80001) as 82ec87938e3d539b2cad36503f75d907dcead280
6 years, 3 months ago (2014-09-24 03:47:27 UTC) #7
commit-bot: I haz the power
6 years, 3 months ago (2014-09-24 03:48:03 UTC) #8
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/93778c0cb6edfe0d5b1146e2797fbac9abadaf14
Cr-Commit-Position: refs/heads/master@{#296341}

Powered by Google App Engine
This is Rietveld 408576698